-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a working prototype for AMP lightbox in ads #7743
Comments
Also requested in #2736 |
This needs further discussion. Personal opinion is that it would be bad UX.
Proof of concept done for AMP host + A4A. Non-AMP host + A4A case needs further thought.
I think this is part of a larger story concerning nested AMP documents rather than the lightbox element itself. @lannka, wdyt?
This is a good possible optimization. Two things:
|
It should NOT go to full screen mode. But rather to the "lightbox" mode (see
For Non-AMP host we need to ask around to see what strategies are used today. There gotta be some protocol to allow this.
@aghassemi had a fuller story on this. |
Updated.
Done for lightbox mode. Refactoring and testing for feature is required before being able to whitelist.
More context required, will update on Monday.
Embedding external documents is out of scope for this feature. Since the feature uses a normal
As mentioned, partial AMP documents are already supported. Embedding documents is out of scope.
Prefetching is out of scope since this does not support embedding external documents. Prerendering is a premature optimization. Added: Create a container |
Closing as "working prototype" has been created. Full feature will be figured out later. |
Related to Whitelist amp-lightbox as part of an AMP ad #7015
amp-ad-banner
tag that will define the content to be repositioned when resizing the iframe into lightbox mode.CC @dvoytenko @lannka
The text was updated successfully, but these errors were encountered: