Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-app-banner: doesn't open in chrome ios #9077

Closed
muxin opened this issue May 1, 2017 · 3 comments
Closed

amp-app-banner: doesn't open in chrome ios #9077

muxin opened this issue May 1, 2017 · 3 comments
Assignees
@muxin
Labels
P1: High Priority
Milestone
Sprint H2 May

Comments

@muxin
Copy link
Contributor

muxin commented May 1, 2017

Repro:
open https://amphtml-nightly.herokuapp.com/examples/article.amp.html
clicking on the Open in App button doesn't open the deep link
/cc @ericlindley-g
@muxin muxin self-assigned this May 1, 2017
@ericlindley-g ericlindley-g added this to the Backlog Bugs milestone May 1, 2017
@muxin muxin mentioned this issue May 1, 2017
Closed
@ericlindley-g
Copy link
Contributor

Also may be repro'd on Firefox + Android

/cc @aghassemi

@aghassemi aghassemi mentioned this issue May 11, 2017
Closed
@aghassemi aghassemi changed the title amp-app-banner: doesn't open in chrome ios amp-app-banner: doesn't open in chrome ios and FF/android May 12, 2017
@aghassemi aghassemi modified the milestones: Sprint H2 May, Backlog Bugs May 22, 2017
@muxin muxin changed the title amp-app-banner: doesn't open in chrome ios and FF/android amp-app-banner: doesn't open in chrome ios May 23, 2017
@muxin
Copy link
Contributor Author

muxin commented May 23, 2017

I'll create a separate issue for android firefox after verifying the repro.

@muxin muxin mentioned this issue May 23, 2017
Merged
@muxin muxin removed the Type: Bug label May 24, 2017
@muxin
Copy link
Contributor Author

muxin commented May 24, 2017

FYI, I tested and verified that for android firefox, both the non-embedded and embedded cases work fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muxin muxin

Labels
P1: High Priority
Projects
None yet
Milestone
Sprint H2 May
Development

No branches or pull requests
3 participants
@aghassemi @muxin @ericlindley-g