Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected date still highlighted even when you've cleared the date #346

Closed
darrenhaken opened this issue Feb 19, 2014 · 2 comments
Closed

Comments

@darrenhaken
Copy link

  1. Select a date such as 19th April 2014
  2. Reopen pickadate and click clear
  3. Reopen pickadate and 19th will still be highlighted.

Also the 19th is highlighted on every month, not just specifically 19th April 2014.

Tested in Chrome & Firefox

Happy to contribute and help solve this issue (if I can)

@amsul
Copy link
Owner

amsul commented Mar 5, 2014

This isn’t a bug..it’s the expected behavior. There needs to be a visual cue as to where the user’s “caret” is focused.

There’s a couple things going on here:

  1. On page load, select is null and highlight is whatever date it currently is.
  2. When a date is clicked to get picked, the select and highlight value update to reflect this new date.

Now, I did just notice a bug while verifying this, but the third step should be:

  1. When the value is cleared, highlight remains unaffected as that’s the last place the caret was at - and select should reset to null. However, select is not being reset at the moment.

I will look into getting a fix out for this soon..

@amsul amsul added the todo label Mar 5, 2014
@amsul amsul added this to the v3.4.1 milestone Mar 5, 2014
@amsul
Copy link
Owner

amsul commented Apr 12, 2014

closing this in favor of #387 which has been resolved.

@amsul amsul closed this as completed Apr 12, 2014
@amsul amsul removed this from the v3.4.1 milestone Apr 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants