Added close button to pickadate - this closes the modal without affecting the currently selected date #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f828b53. Conflicts: api.htm lib/compressed/picker.date.js lib/compressed/picker.js lib/compressed/picker.time.js lib/picker.date.js
|
@darrenhaken thanks for this! Could you possibly clean up the PR by reverting changes that aren’t directly related to the “close” button? It’ll make my life much easier in seeing the relevant diff. |
added 2 commits
July 10, 2014 09:54
…ect for the users timezone. For example 'Wed Jul 23 2014 00:00:00 GMT+0100 (BST)' should be interpretted as 23 July, 2014'. Added .idea to gitignore for JetBrains IDEs.
…isted in the code base through unused variables/functions in demo.js
|
@amsul I've updated the PR so that the Close Button feature does not contain the style changes in the last commit (sorry about that!). I have also reverted the UTC changes and added the local time test so that functionality is restored to v 3.5.2. My suggestion is to look into UTC further and reapply it when the implications are understood. -Darren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d date.
Added .idea to gitignore to ignore JetBrains IDE config files
Executing grunt default caused jshint errors as some variables are not in use. Removed unused variables and now all tasks run fine
Encapsulated the creation of the 3 different sections of the calendar in picker.date.js
Resolved error in grunt file with addtional ',' added.