feat: Table and Column Lineage Polish #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwom
requested review from
allisonsuarez,
dikshathakur3119,
dorianj,
feng-tao,
Golodhros and
ttannis
as code owners
danwom
commented
Apr 14, 2021
| @@ -6,16 +6,16 @@ import * as React from 'react'; | |||
| import './styles.scss'; | |||
|
|
|||
| const ShimmeringDashboardLoader: React.FC = () => ( | |||
There was a problem hiding this comment.
Using the pattern of ShimmeringXLoader seems somewhat verbose with both a prefix and a suffix. I almost named my loader as ShimmeringColumnListLineageLoader.
How do you feel about adopting either XLoader or XShimmer for these types of components?
There was a problem hiding this comment.
What about just ShimmeringColumnLineageLoader?
There was a problem hiding this comment.
Sounds good!
Ideally, we should come up with a generic component that packs all this in one. At some point!
added 4 commits
April 14, 2021 12:29
- Reordeered upstream/downstream tabs - Hide upstream/downstream tabs when no tables are found - Add loading state for column lineage Signed-off-by: Daniel Won <dwon@lyft.com>
Signed-off-by: Daniel Won <dwon@lyft.com>
Signed-off-by: Daniel Won <dwon@lyft.com>
Signed-off-by: Daniel Won <dwon@lyft.com>
Golodhros
reviewed
Apr 14, 2021
| } | ||
|
|
||
| &.header { | ||
| height: 24px; |
There was a problem hiding this comment.
Suggested change
| height: 24px; | |
| height: $shimmer-header-height; |
Golodhros
reviewed
Apr 14, 2021
| @import 'variables'; | ||
|
|
||
| $shimmer-height: 120px; | ||
| $shimmer-block-spacing: $spacer-2; |
There was a problem hiding this comment.
Nit: I feel this is a bit too much, I would make it spacer-1
Signed-off-by: Daniel Won <dwon@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
General UX polish for lineage features
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.