Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table Lineage API #262

Merged
merged 28 commits into from
Mar 4, 2021
Merged

feat: Table Lineage API #262

merged 28 commits into from
Mar 4, 2021

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Feb 26, 2021

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

  • Created Table Lineage API
  • Added Column to ResourceType enum
  • Bumped version of amundsen-common
  • Bumped version of marshmallow and marshmallow-annotations to align with amundsen-common
  • Updated tests and uses of marshmallow to new version

Tests

  • Wrote tests for Table Lineage API
  • Updated users test to work with marshmallow update
  • Manually tested API calls

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez force-pushed the asm-table-lineage-api branch from 4f0a39a to dc19bf1 Compare March 3, 2021 20:46
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@amundsen-io amundsen-io deleted a comment from codecov-io Mar 3, 2021
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review March 3, 2021 23:37
metadata_service/api/__init__.py Show resolved Hide resolved
metadata_service/api/__init__.py Show resolved Hide resolved
metadata_service/api/popular_tables.py Show resolved Hide resolved
metadata_service/api/table.py Show resolved Hide resolved
@allisonsuarez allisonsuarez requested a review from feng-tao March 4, 2021 16:53
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez merged commit e306034 into master Mar 4, 2021
@allisonsuarez allisonsuarez deleted the asm-table-lineage-api branch March 4, 2021 19:26
('git+https://www.github.com/hilearn/marshmallow-'
'annotations.git@a7a2dc96932430369bdef36555082df990ed9bef#egg=marshmallow-annotations')
],
install_requires=[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allisonsuarez is there a reason we removed the requirements file from the install_requires? as it breaks the projects if we simply install metadata using setup.py, and hence via pip. Or it's just a typo?

cc: @feng-tao

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah removed it because it breaks when you get to the link line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants