Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Column badges in Atlas Proxy #263

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Feb 28, 2021

Signed-off-by: mgorsk1 gorskimariusz13@gmail.com

Summary of Changes

This PR introduces support for surfacing column badges in Atlas Proxy.

Tests

TBD

Documentation

n/a

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@mgorsk1 mgorsk1 force-pushed the feat/column_badges_in_atlas branch from 7fc02a0 to 0d80dc7 Compare February 28, 2021 19:00
@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #263 (79fa0e2) into master (2752492) will increase coverage by 3.19%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   74.10%   77.29%   +3.19%     
==========================================
  Files          25       27       +2     
  Lines        1255     1370     +115     
  Branches      136      164      +28     
==========================================
+ Hits          930     1059     +129     
+ Misses        297      262      -35     
- Partials       28       49      +21     
Impacted Files Coverage Δ
metadata_service/api/__init__.py 82.60% <ø> (ø)
metadata_service/api/column.py 100.00% <ø> (ø)
metadata_service/api/popular_tables.py 100.00% <ø> (ø)
metadata_service/api/system.py 66.66% <ø> (ø)
metadata_service/api/user.py 100.00% <ø> (ø)
metadata_service/proxy/statsd_utilities.py 81.25% <ø> (ø)
metadata_service/util.py 100.00% <ø> (ø)
metadata_service/proxy/shared.py 28.57% <28.57%> (ø)
metadata_service/api/badge.py 61.29% <61.29%> (ø)
metadata_service/proxy/neo4j_proxy.py 71.55% <61.53%> (-3.45%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a765424...79fa0e2. Read the comment docs.

@mgorsk1 mgorsk1 force-pushed the feat/column_badges_in_atlas branch from 0d80dc7 to 79fa0e2 Compare March 1, 2021 13:06
@mgorsk1 mgorsk1 marked this pull request as ready for review March 1, 2021 13:07
@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Mar 1, 2021

cc @verdan

Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Copy link
Member

@verdan verdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Would be nice to add/update the test cases.

Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
@mgorsk1 mgorsk1 force-pushed the feat/column_badges_in_atlas branch from 79fa0e2 to 0fd16f7 Compare March 3, 2021 19:36
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
@mgorsk1 mgorsk1 merged commit a3efb4c into amundsen-io:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants