Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Unexplicit throw in MinibatchInferenceLoop if batch_size is larger than dataset size #191

Open
pabfer opened this issue Jul 6, 2019 · 1 comment
Labels
bug Something isn't working Easy

Comments

@pabfer
Copy link

pabfer commented Jul 6, 2019

Describe the bug

If batch_size for MinibatchInferenceLoop is larger than the dataset size, this line throws due to division by zero.

Expected behavior

Possible mitigations are:

  • Option No. 1: Default batch size to min("requested batch size", "dataset size") and issue a warning if "requested batch size" > "dataset size".
  • Option No. 2: Throw with a message stating why it's throwing and how to fix the issue.

Desktop:

  • OS: Ubuntu 18.04.2
  • Python version: 3.6
  • MXNet version: 1.4.1
  • MXFusion version: 0.3.1
  • MXNet context: CPU
@meissnereric meissnereric added bug Something isn't working Easy labels Jul 10, 2019
@DerrickGXD
Copy link

thank you for issuing this problem. I have created a pull request to resolve this in the deploy branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Easy
Projects
None yet
Development

No branches or pull requests

3 participants