Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map multibindings #48

Open
matejdro opened this issue Oct 17, 2024 · 2 comments · May be fixed by #86
Open

Map multibindings #48

matejdro opened this issue Oct 17, 2024 · 2 comments · May be fixed by #86
Labels
enhancement New feature or request

Comments

@matejdro
Copy link

matejdro commented Oct 17, 2024 •
edited
Loading

Any chance a support for contributing to a map multibinding could be added?

Would adding a key property to the contributes annotation work?
@vRallev vRallev added the enhancement New feature or request label Oct 17, 2024
@vRallev
Copy link
Contributor

vRallev commented Oct 17, 2024

I don't see why not.

@simonlebras simonlebras linked a pull request Nov 15, 2024 that will close this issue
Open
@bddckr
Copy link

bddckr commented Jan 25, 2025

This is the last reason I can't move my projects away from Dagger+Anvil yet.

Is anything required to get the linked PR over the finish line and get a release out with it? I can see there's a question in the PR to add support for LazyClassKey, but IMO that can be added another time. The PR seems to resolve the original request of getting maps working for multibindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for multi-binding map codegen simonlebras/kotlin-inject-anvil
3 participants
@bddckr @matejdro @vRallev