-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
srt file support without transcoding #35
Comments
I haven't worked on that. I believe there are ways to advertise srt files to the player, or you can transcode them "hard sub" style, but you'd have to tinker with that. I'd definitely accept contributions that implement this. |
I would like to implement subtitle support but dont know where to start :(. |
It's definitely possible. I don't have access to a suitable DNLA player anymore that would allow me to test an implementation for robustness. This guy nails it: http://superuser.com/a/645519/15896 I find no useful mention of subtitles in any specs I have. It seems it's player dependent, which defeats the purpose of having a spec in the first place. |
Your best bet it would seem is to ensure the SRT file is exposed, or readable from the server. Most schemes that have this working for external subtitles seem to rely on the name matching minus the extension. This convention is also used by non-DLNA players. I don't believe DMS currently exposes SRTs by default, you could start by adding an exception for those files. That occurs here: https://github.com/anacrolix/dms/blob/master/dlna/dms/cds.go#L57 |
Why not stream a mkv containing the original video and the subs? (so no transcoding at all) |
Yes that will put all the responsibility on the player, which is a smart work around (assuming your player supports it). |
mkv is the standard being used for the official DivX Plus HD format. |
@anacrolix The mime type of a |
@hemantmits @tYYGH would you be able to try out and/or comment on #79? |
Does dms support srt file over dlna without transcoding ?
I tried dms on my rpi 2 but its not sending subtitle to my LG tv.
Video works fine.
The text was updated successfully, but these errors were encountered: