Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support review folder #167

Open
npquynhdo opened this issue Nov 21, 2024 · 9 comments
Open

Support review folder #167

npquynhdo opened this issue Nov 21, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@npquynhdo
Copy link

Instead of ignoring multiple files/folder. Isn't better to support a review folder?
Something like :

steps:
  - uses: anc95/ChatGPT-CodeReview@main
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
      PATH: ./src
@anc95 anc95 self-assigned this Nov 22, 2024
@anc95 anc95 added the enhancement New feature or request label Nov 22, 2024
@anc95
Copy link
Owner

anc95 commented Nov 22, 2024

@npquynhdo just added INCLUDE_PATTERNS support

steps:
  - uses: anc95/ChatGPT-CodeReview@main
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
      INCLUDE_PATTERNS: src/

@npquynhdo
Copy link
Author

@anc95 Thank you for adding the feature...
It seems like the bot still read other files and folders even though INCLUDE_PATTERNS is in place
image

@anc95
Copy link
Owner

anc95 commented Nov 25, 2024

@npquynhdo in the screenshot, seems that the review comment was sent by the bot service, I think you are using the bot service right? If yes and the service is self-deployed, you should add the config env variable in the .env file and restart the service to make it take effect. the bot service provided by me doesn't support custom variables yet.

@npquynhdo
Copy link
Author

@anc95 Ah I understand. So if I understand correctly, to have this works I should uninstall the bot and only use as the GitHub action?

@anc95
Copy link
Owner

anc95 commented Nov 25, 2024

@npquynhdo yes

@npquynhdo
Copy link
Author

npquynhdo commented Dec 3, 2024

@anc95 doesn't work (see the pictures) , but when I took the INCLUDE_PATTERNS: src/ out it works...but it runs through all the code base but not only files under the src folder
image
image

@anc95
Copy link
Owner

anc95 commented Dec 11, 2024

@npquynhdo just fixed.

@npquynhdo
Copy link
Author

@anc95 Still not working. It seems to not detect changes in the /src folder even though I've included it as: INCLUDE_PATTERNS: src/

@anc95
Copy link
Owner

anc95 commented Dec 16, 2024

hi @npquynhdo please try to change to /src/**/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants