Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checksum & artifact signing #1513

Closed
hibare opened this issue Sep 22, 2023 · 6 comments · Fixed by #1535
Closed

Implement checksum & artifact signing #1513

hibare opened this issue Sep 22, 2023 · 6 comments · Fixed by #1535
Assignees
Labels
enhancement New feature or request

Comments

@hibare
Copy link
Contributor

hibare commented Sep 22, 2023

What would you like to be added:
Implement artificats signing using cosign.

Why is this needed:
Grype currently publishes release binaries on its GitHub release page, and provides users with important software artifacts. But ensuring the authenticity and authenticity of these objects requires a more robust tool than simply relying on provided checksums This feature request proposes a solution that leverages the capabilities of Goreleaser , which Grype uses to create and release artifacts In order to increase the security and reliability of the release.

Additional context:

GoReleaser cosign integration

@hibare hibare added the enhancement New feature or request label Sep 22, 2023
@hibare
Copy link
Contributor Author

hibare commented Sep 25, 2023

Goreleaser offers support for signing artifacts using Cosign, which provides two distinct methods for accomplishing this task: key-based signing and keyless signing. Key-based signing necessitates the maintenance of a key pair, whereas keyless signing does not. I would appreciate it if you could inform me of the preferred method favored by the maintainers. I am eager to submit a pull request accordingly.

@wagoodman
Copy link
Contributor

wagoodman commented Sep 25, 2023

The keyless approach would be preferred here, especially since we're releasing from a github actions runner (leveraging OIDC tokens).

I am eager to submit a pull request accordingly.

Shout out if you have more questions you feel we should answer before getting started but also feel free to jump in if you have enough info 🙌 We have our community meeting this thursday too as another option to chat about the details as well.

In the meantime I'll assign the issue to you as a signal to others that it's in-flight work.

@hibare
Copy link
Contributor Author

hibare commented Sep 26, 2023

I think I have enough info to get started, will open a PR in couple of days. I'll post here if there are any questions.

@wagoodman wagoodman moved this to In Progress in OSS Sep 28, 2023
@wagoodman wagoodman self-assigned this Sep 28, 2023
@pandatix
Copy link

pandatix commented Oct 7, 2023

Hey, we may want to implement SLSA Build Level 3 as it supports this pattern and is battle tested + fits the goreleaser process.
Here are some references to start with:

@spiffcs
Copy link
Contributor

spiffcs commented Oct 9, 2023

@pandatix thanks so much for the references

@hibare
Copy link
Contributor Author

hibare commented Oct 10, 2023

Hey, we may want to implement SLSA Build Level 3 as it supports this pattern and is battle tested + fits the goreleaser process. Here are some references to start with:

Will check it out

@wagoodman wagoodman moved this from In Progress to In Review in OSS Oct 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in OSS Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants