Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split v1-5 DB distribution concerns to a new legacy package #2124

Closed
wagoodman opened this issue Sep 17, 2024 · 0 comments · Fixed by #2144
Closed

Split v1-5 DB distribution concerns to a new legacy package #2124

wagoodman opened this issue Sep 17, 2024 · 0 comments · Fixed by #2144
Assignees
Milestone

Comments

@wagoodman
Copy link
Contributor

With grype DB v6 we'll be tracking all distribution concerns with the schema instead of something that is shared across schemas (e.g. DB curator, listing file shape, metadata file shape, etc). This issue is just in place to migrate existing code to make room for the new schema and distribution concerns.

Todays layout:

grype/db
├── v1/
├── v2/
├── v3/
├── v4/
├── v5
│   └── ...
├── curator.go           # used to search for and download DBs
├── listing.go           # listing.json definition for distribution
├── metadata.go          # metadata.json definition for distribution
├── status.go            # db status command support
└──*_provider.go         # higher-level DB access helpers (provides GetByDistro, GetByCPE, GetByLanguage, etc)

Proposed layout:

grype/db
├── legacy
│   └── distribution                    # support v1-5 distribution concerns
│       ├── curator.go
│       ├── listing.go
│       ├── metadata.go
│       └── status.go
├── v1/
├── v2/
├── v3/
├── v4/
├── v5/
└── v6/
    ├── distribution                # future code...
    │   └── ...
    ├── installation                # future code...
    │   └── ...
    └── ...

This will mean updating grype-db to additionally use these updated paths.

@wagoodman wagoodman added enhancement New feature or request breaking-change labels Sep 17, 2024
@wagoodman wagoodman added this to the DB v6 milestone Sep 17, 2024
@wagoodman wagoodman removed the enhancement New feature or request label Sep 17, 2024
@wagoodman wagoodman moved this to Ready in OSS Sep 17, 2024
@wagoodman wagoodman self-assigned this Sep 26, 2024
@wagoodman wagoodman moved this from Ready to In Progress in OSS Sep 26, 2024
@wagoodman wagoodman moved this from In Progress to In Review in OSS Sep 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in OSS Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant