-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java archive cataloger performance in 0.82.x much slower than 0.81.0 #2200
Comments
Hi @driseley - thanks for the issue report and for providing an easily reproducible example. I tried reproducing here on my system, running this twice, to ensure it was all downloaded before starting.
grype v0.81.0
grype v0.82.0
grype v0.82.1
I suspect this may be related to Grype v0.82.0 including Syft v1.14.0. In Syft v1.13.0, we landed some changes which likely affected Java heavy containers. |
Thanks for coming back so quicky @popey . Is this considered a bug, or just what we need to expect now? For some of our internal images (which I can't share) the scan times have gone from 10secs to 2 mins, and we have pipelines that produce 10 java images - so the cumulative effect of this is quite pronounced? |
Sorry that this is causing you pronounced issues. I appreciate this is not desirable. |
Thanks for that, just wanted to know if it was going to be addressed in the future. For now we have reverted to the earlier version, which is fine for us for now. Thanks again for looking at this |
Thanks for your patience. It's being looked at right now by the Best People. 😄 |
@wagoodman / @popey - many thanks for the fast fix, I can confirm performance for us has returned to the 0.81 levels |
What happened:
When upgrading grype from 0.81.0 to 0.82.1 (but also 0.82.0) the performance of scanning java heavy containers has decreased significantly
What you expected to happen:
The performance would be similar
How to reproduce it (as minimally and precisely as possible):
Using
-vv
:[0007] INFO task completed elapsed=3.801204512s task=java-archive-cataloger
Using
-vv
:[0027] INFO task completed elapsed=22.68268451s task=java-archive-cataloger
Anything else we need to know?:
Environment:
grype version
:cat /etc/os-release
or similar):The text was updated successfully, but these errors were encountered: