Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rather than have a hard max recursive depth - syft should detect parent pom cycles #2284

Closed
spiffcs opened this issue Nov 2, 2023 · 2 comments · Fixed by #2769
Closed
Assignees

Comments

@spiffcs
Copy link
Contributor

spiffcs commented Nov 2, 2023

What would you like to be added:
Syft currently has a hard coded cut off for max recursive depth for searching for a parent pom. There is some room where the code could be written to detect cycles, but it was unclear at the time of writing the pom parent look up if that cycles can be exited in this way.

Why is this needed:
More options of searching maven for pom documents with the correct information

Additional context:
#2274 (comment)

@kzantow
Copy link
Contributor

kzantow commented Jul 30, 2024

Hey @spiffcs -- #2769 will sorta fix this, but there still is a relatively large parent depth of 10 by default. Do you think we should get rid of the depth altogether? Either way, we need to leave the parameter for backwards compatiblity, I think, until Syft 2.0.

@kzantow
Copy link
Contributor

kzantow commented Jul 31, 2024

Actually, I revisited this behavior in #2769 and disabled the depth check by default, since the code was already checking for cycles, so I think this can be considered fixed by that PR.

@spiffcs spiffcs closed this as completed Aug 1, 2024
@kzantow kzantow removed the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants