Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support attaching attestation right after generate it #990

Closed
developer-guy opened this issue May 9, 2022 · 3 comments
Closed

support attaching attestation right after generate it #990

developer-guy opened this issue May 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@developer-guy
Copy link
Contributor

developer-guy commented May 9, 2022

What would you like to be added:

While reading the blog post on Anchore's website about generating attestations with Syft (really excellent blog post, btw), We've noticed that to attach attestations to the image Syft requires additional cosign command, so, we can provide the same functionality in Syft without requiring other cosign command by simply adding a new flag named --attach or --load, etc.

Why is this needed:

Eliminating the second command to attach attestation to the image

Additional context:

cc: @Dentrax

@developer-guy developer-guy added the enhancement New feature or request label May 9, 2022
@Dentrax
Copy link

Dentrax commented May 10, 2022

+1, this one very straightforward task that we can handle this in Run() function. Eventually UX will be:

- $ syft attest --key ./cosign.key <my-image> -o cyclonedx-json > ./my-image-sbom.att.json
- $ cosign attach attestation <my-image> --attestation ./my-image-sbom.att.json
vs.
+ $ syft attest --attach --key ./cosign.key <my-image> -o cyclonedx-json

@developer-guy
Copy link
Contributor Author

Fixed by: #910

@developer-guy
Copy link
Contributor Author

Screen Shot 2022-05-11 at 22 20 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants