Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to old version of nix in shell.nix #97

Open
crop2000 opened this issue Jul 26, 2024 · 4 comments
Open

to old version of nix in shell.nix #97

crop2000 opened this issue Jul 26, 2024 · 4 comments

Comments

@crop2000
Copy link
Contributor

crop2000 commented Jul 26, 2024

on master the version of nix is to old to be used with the code provided in src/default.nix (on master)
it fails because fetchGit does not yet suport submodules.

@crop2000
Copy link
Contributor Author

reproducer in npins checkout folder:

cargo run -- upgrade
cargo run -- add git https://git.lix.systems/lix-project/lix
nix-instantiate --eval npins -A lix.outPath
error: unsupported argument 'submodules' to 'fetchGit', at /home/olaf/projects/rust/forks/npins_project/npins/default.nix:69:16

@crop2000
Copy link
Contributor Author

@andir you said here that you don't want to update the minimum required version of nix. But it is already broken with current npins.

@andir
Copy link
Owner

andir commented Nov 26, 2024

What would be the minimum required version that supports this? Could we throw a warning within the default.nix whenever the version is too old and someone tries to use submodules?

@crop2000
Copy link
Contributor Author

currently npins is incompatible with 2.3.18 independent from the question if submodule is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants