Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid module: incomplete support for fingers{} and count{} #8

Open
andr-ew opened this issue Oct 25, 2020 · 1 comment
Open

grid module: incomplete support for fingers{} and count{} #8

andr-ew opened this issue Oct 25, 2020 · 1 comment
Labels
bug Something isn't working refactor
Milestone

Comments

@andr-ew
Copy link
Owner

andr-ew commented Oct 25, 2020

unsupported:
momentary.fingers (kind of works but buggy)
toggle.fingers
toggle.count when toggle.edge == 0
trigger.count
trigger.fingers[2] acts more like trigger.count[2]

value is the correct implementation of fingers, momentary & toggle is the correct implementation of count

TODO: refactor binary and most of the other handlers to mimic these correct behaviors. this will probably take the form of helper functions or sub-objects rather than supertypes, this way the new behaviors can be shared by controls in other modules (_key). maybe some specialized helper tools would make sense within the core module.

@andr-ew andr-ew added the bug Something isn't working label Oct 26, 2020
@andr-ew andr-ew changed the title grid module: incomplete support for fingers{} and count{} grid module: incomplete support for fingers{} and count{} + repetitive code Nov 18, 2020
@andr-ew andr-ew changed the title grid module: incomplete support for fingers{} and count{} + repetitive code grid module: incomplete support for fingers{} and count{} Sep 20, 2021
@andr-ew andr-ew added this to the 1.2 milestone Sep 20, 2021
@andr-ew
Copy link
Owner Author

andr-ew commented Nov 20, 2021

added support for trigger.fingers and toggle.fingers but only in the 1d routines, logic needs to be mirrored in the 2d routines

andr-ew/nest@9f51c6d
andr-ew/nest@439caca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

No branches or pull requests

1 participant