chore(refactoring): organizing code

Author: andre-filho

.editorconfig

@@ -2,7 +2,7 @@
 charset = utf-8
 indent_style = space
 end_of_line = lf
-trim_trailing_whitespace = false
+trim_trailing_whitespace = true
 indent_size = 2
 
 [*.py]

.gitignore

@@ -1,3 +1,5 @@
 .vscode/
 commiter.yml
 __pycache__/
+package.json
+package-lock.json

generator.py

@@ -1,5 +1,6 @@
 #! /usr/bin/env python3
 
+# dependencies imports
 from pathlib import Path
 from yaml import safe_load
 from yaml import YAMLError
@@ -10,33 +11,23 @@
 from conventions.symphony_cmf import symphony_convention
 from conventions.no_convention import just_message
 
+# utils imports
 from utils import create_file
-from utils import supported_conventions as convention_list
+from utils import menu
+from utils import parser_cli
 
-import argparse
 
-parser = argparse.ArgumentParser()
-parser.add_argument("--co-author",
-                    help="make your friend an co-author to the commit",
-                    dest="co_author", default=None)
-parser.add_argument("--no-generate",
-                    help="disables the creation of a commiter.yml file",
-                    default=True, type=bool)
-parser.add_argument('--convention', choices=convention_list,
-                    help="selects a convention to be used for the commit")
-parser.parse_args()
+parser = parser_cli()
 
 file_path = Path('commiter.yml')
 if file_path.is_file():
     with open(str(file_path), 'r') as stream:
         try:
             config = safe_load(stream)
-
             if config['convention'] is not None:
                 convention = str(config['convention']).lower()
             else:
                 convention = 'none'
-
             if convention == 'angular' or convention == 'karma':
                 print('You are using the %s convention' % convention)
                 angular_convention()
@@ -48,23 +39,11 @@
                 symphony_convention()
             elif convention == 'none':
                 just_message()
-            elif convention == 'custom':
-                custom_convention()
-
         except YAMLError as exc:
             print(exc)
 else:
     print("No config files found!\nRunning default script...")
-    opt = int(input("""
-    what type of commit convention are you using?
-
-    default: Just the message
-    1: Karma/Angular
-    2: Conventional changelog
-    3: Symfony CMF
-
-    """) or 4)
-
+    opt = int(input(menu) or 4)
     if opt == 1:
         print("You're using the angular convention")
         angular_convention()

test/test_conventions.py

@@ -1,4 +1,4 @@
-import pytest
+# import pytest
 # import conventions.karma_angular as angular
 # import conventions.changelog as changelog
 # import convention.symphony_cmf as symphony

test/test_utils.py

@@ -1,4 +1,3 @@
-import pytest
 import utils
 import yaml
 

utils.py

@@ -1,12 +1,23 @@
+import argparse
 from yaml import dump
 
 supported_conventions = [
     "angular",
     "changelog",
-    "symphony",   
+    "symphony",
     "message_only",
 ]
 
+menu = """
+    what type of commit convention are you using?
+
+    default: Just the message
+    1: Karma/Angular
+    2: Conventional changelog
+    3: Symfony CMF
+
+    """
+
 def get_text(context=False):
     if context:
         tag = str(input("type the tag: "))
@@ -25,3 +36,17 @@ def create_file(convention_name):
     )
     with open('commiter.yml', 'w') as output_file:
         dump(data, output_file, default_flow_style=False)
+
+
+def parser_cli():
+    parser = argparse.ArgumentParser()
+    parser.add_argument("--co-author",
+                        help="make your friend an co-author to the commit",
+                        dest="co_author", default=None)
+    parser.add_argument("--no-generate", dest="no_file",
+                        help="disables the creation of a commiter.yml file",
+                        default=True, type=bool)
+    parser.add_argument('--convention', choices=supported_conventions,
+                        dest="convention",
+                        help="selects a convention to be used for the commit")
+    parser.parse_args()