Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopTip's containerView incorrectly fires tapHandler #116

Closed
ronaldsmartin opened this issue May 12, 2017 · 1 comment
Closed

PopTip's containerView incorrectly fires tapHandler #116

ronaldsmartin opened this issue May 12, 2017 · 1 comment

Comments

@ronaldsmartin
Copy link

Hi, thanks for building this!

In the new Swift version of the pop tip, you're adding the gesture recognizer for tapHandler to the poptip's container view instead of to the pop tip itself (line 511). This results in the tapHandler getting fired when tapping outside the pop tip, which is a regression from the previous version.

You may need to have separate gesture recognizers for handling taps inside and outside the poptip. 😄

@andreamazz
Copy link
Owner

Hey @ronaldsmartin, nice catch! Thanks, should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants