-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use masked arrays? #5
Comments
@alexbovet I've never used the masked array functionality but it isn't about handling missing data - the underlying Fortran implementation is not set up for this (and I believe this is mentioned in the original paper). While the weights are passed in to the Fortran I'm guessing this functionality is there just to allow extracting some sort of slice from a python array to pass down to the STL, but I'm not sure. In my Java implementation, I've considered exposing the weights externally for exactly this purpose - the implementation looks like it would be straightforward to modify to ignore missing values, assuming there are enough points available to do the sub-cycle interpolation to the missing point. But it isn't high on my list right now. |
ok, thanks a lot for the clarifications and thanks for the python3 implementation! |
Hi,
I don't understand how to use masked arrays with stl.
returns:
ValueError: Masked arrays should be filled first!
In the code (mpyloess.py), I see that there is a check:
So any masked arrays will raise this error.
If I try with
yma.filled()
instead, the fit does take the filled values into account, which is not what I want for masked arrays.Is it possible to use masked arrays, I understood that STL could deal with missing data.
Note that I am using @jcrotinger's fork for Python 3.
Thanks!
The text was updated successfully, but these errors were encountered: