Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make query time accessible through Jinja template syntax #13

Open
addisonklinke opened this issue Aug 27, 2023 · 1 comment
Open

Make query time accessible through Jinja template syntax #13

addisonklinke opened this issue Aug 27, 2023 · 1 comment

Comments

@addisonklinke
Copy link

First off thanks for this amazing project! It automates so much of the front-end boilerplate for dashboards

I'm new to BQL and can tell that my queries (both number and complexity) are rather inefficient based on the load time for a dashboard page. After all the plumbing works, I'd like to go back and optimize this. It'd be really convenient if fava-dashboards recorded the total query time and made it accessible through Jinja like {{queries[i].time}}. This way I could render it on the page itself as feedback

@andreasgerstmayr
Copy link
Owner

I think the query duration could be exposed in the logs (debug log level), and possible for queries taking longer than some threshold a different log level (warn).

I won't have time to work on this, but I'm happy to help/review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants