Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse-ci doesn't explain why it failed #60

Closed
elgalu opened this issue Jan 27, 2020 · 1 comment · Fixed by #80
Closed

lighthouse-ci doesn't explain why it failed #60

elgalu opened this issue Jan 27, 2020 · 1 comment · Fixed by #80
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed

Comments

@elgalu
Copy link

elgalu commented Jan 27, 2020

Hi, thanks for this great tool!

lighthouse-ci doesn't explain why it failed

accessibility: 92
best-practices: 86
seo: 100
pwa: 77
Failed. ❌

Error: lighthouse-ci test failed.

It would be nice to output per line failed assertions, e.g. failed due to pwa < 80
@andreasonny83
Copy link
Owner

Thanks for reporting this @elgalu
I'll try to add more messages. However, PRs are always welcome if you want to contribute

@andreasonny83 andreasonny83 added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2020
@andreasonny83 andreasonny83 pinned this issue Oct 3, 2020
@andreasonny83 andreasonny83 mentioned this issue Oct 3, 2020
Merged
@andreasonny83 andreasonny83 unpinned this issue Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(calculate-results): Add better failure messages andreasonny83/lighthouse-ci
2 participants
@elgalu @andreasonny83