Inner functions' variables are freed

[Naheel-Azawy]

Having the following js:

function foo() {
    var s = "a";
    function bar(a) {
        s += " hello " + a;
    }
    bar(5);
    return s;
}
console.log(foo());

The expected result is of course a hello 5. However, when checking the c code:

...
void bar(int16_t a, const char ** s)
{
    char * tmp_result_2 = NULL;
    char * tmp_result = NULL;
    tmp_result_2 = malloc(strlen(" hello ") + STR_INT16_T_BUFLEN + 1);
    assert(tmp_result_2 != NULL);
    tmp_result_2[0] = '\0';
    strcat(tmp_result_2, " hello ");
    str_int16_t_cat(tmp_result_2, a);
    tmp_result = malloc(strlen(*s) + strlen(tmp_result_2) + 1);
    assert(tmp_result != NULL);
    tmp_result[0] = '\0';
    strcat(tmp_result, *s);
    strcat(tmp_result, tmp_result_2);
    (*s = tmp_result);
    free((char *)tmp_result); // <===== This should not be freed here!!!
    free((char *)tmp_result_2);
}
const char * foo()
{
    const char * s;
    s = "a";
    bar(5, &s);
    return s;
}
...

[andrei-markeev]

true. thanks for reporting! 👍
will fix

[bil-ash]

@andrei-markeev Any ETA of the fix? Multiple issues in this repo have been created which are actually manifestations of (this) same bug. Please fix this soon.

[andrei-markeev]

@bil-ash, nope, no ETAs