Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to upgrade to Apollo Server v4 | remove deprecated dependencies #96

Open
stpru24 opened this issue Mar 12, 2024 · 2 comments
Open

Comments

@stpru24
Copy link

stpru24 commented Mar 12, 2024

Hi @andrejpk ,

Noticed that with Apollo Server v4, apollo-datasource package has been deprecated and will hit EOL on 22 October 2024.
Reference - https://www.npmjs.com/package/apollo-datasource

Could you please consider making the required changes to remove the apollo-datasource dependency?

Thanks

@andrejpk
Copy link
Owner

Hi @stpru24 , I noticed that in my last push of dependency updates. I'd like to make that change. I only spent about 5 min looking into it so far. Is that's a backward -compatible change or would that require a major version change in this library?

Also happy to accept a PR or collaborate if to have some time to try this. It would speed this up.

@stpru24
Copy link
Author

stpru24 commented Mar 13, 2024

Hi @andrejpk , looks like there are some major changes, below dependencies are deprecated with Apollo Server V4 -
"apollo-datasource": "^3.3.2"
"apollo-server-caching": "^3.3.0"
"apollo-server-errors": "^3.3.1"

The KeyValueCache interface has been moved and is now in the @apollo/utils.keyvaluecache package.
The InMemoryLRUCache class has also moved to the @apollo/utils.keyvaluecache package.
https://www.apollographql.com/docs/apollo-server/v3/performance/cache-backends#legacy-caching-implementation

@stpru24 stpru24 changed the title Changes to upgrade to Apollo Server v4 | apollo-datasource deprecated Changes to upgrade to Apollo Server v4 | remove deprecated dependencies Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants