Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT option to include install flags #82

Open
Soviut opened this issue Jun 11, 2022 · 1 comment
Open

FEAT option to include install flags #82

Soviut opened this issue Jun 11, 2022 · 1 comment

Comments

@Soviut
Copy link

Soviut commented Jun 11, 2022

NPM 8 throws an error on peer dependency mismatches. I have an intentional mismatch that I need to ignore with the --legacy-peer-deps install flag.

It would be great if there was an option to pass install flags to the install step.

- uses: andresz1/size-limit-action@v1
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    install_flags: '--legacy-peer-deps'

Right now, I'm trying to use skip_step: install so that I can manually install, but I'm having issues with that approach #81

It seems like it would only be a matter of splitting and passing the flags as the second argument array to exec on this line.

await exec(`${manager} install`, [], {

I might try to make a PR to help out.

@stazcp
Copy link

stazcp commented Jul 21, 2023

did anyone create a PR for install_flags?
skip: install
also not working for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants