Skip to content

Commit 60dffda

Browse files
jh6186andrewc-arm
authored andcommitted
tidy up PR comments ARMmbed#2
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
1 parent d8dca5b commit 60dffda

File tree

3 files changed

+3
-49
lines changed

3 files changed

+3
-49
lines changed

Diff for: targets/TARGET_Samsung/TARGET_SIDK_S5JS100/device/s5js100_systemreset.c

+1-8
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
*
4040
*/
4141

42-
4342
/****************************************************************************
4443
Included Files
4544
****************************************************************************/
@@ -58,19 +57,13 @@
5857
#include "rtx_os.h"
5958
#include <inttypes.h>
6059
#include <string.h>
60+
6161
#ifndef NDEBUG
6262
#define ERROR_REPORT(ctx, error_msg, error_filename, error_line) print_error_report(ctx, error_msg, error_filename, error_line)
6363
static void print_error_report(const mbed_error_ctx *ctx, const char *, const char *error_filename, int error_line);
6464
#else
6565
#define ERROR_REPORT(ctx, error_msg, error_filename, error_line) ((void) 0)
6666
#endif
67-
#if MBED_CONF_PLATFORM_CRASH_CAPTURE_ENABLED
68-
//Global for populating the context in exception handler
69-
//mbed_fault_context_t *const mbed_fault_context = (mbed_fault_context_t *)(FAULT_CONTEXT_LOCATION);
70-
#else
71-
//mbed_fault_context_t fault_context;
72-
//mbed_fault_context_t *const mbed_fault_context = (mbed_fault_context_t *) &fault_context;
73-
#endif
7467

7568
extern mbed_fault_context_t *mbed_fault_context;
7669
static int error_count = 0;

Diff for: targets/TARGET_Samsung/TARGET_SIDK_S5JS100/mbed_sdk_init.c

-2
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,12 @@ void mbed_sdk_init(void)
3131
modifyreg32(0x85026100, 0x3, 0x1);
3232
modifyreg32(0x85026000, 0x3, 0x0);
3333

34-
/* Beetle System Power Config */
3534
SystemPowerConfig();
3635

3736
s5js100_pmip_initialize();
3837

3938
/* Config EFlash Controller Clock */
4039
SFlash_DriverInitialize();
41-
// EFlash_ClockConfig();
4240

4341
sflash_os_env_parser();
4442
}

Diff for: targets/TARGET_Samsung/TARGET_SIDK_S5JS100/port_api.c

+2-39
Original file line numberDiff line numberDiff line change
@@ -49,54 +49,17 @@ PinName port_pin(PortName port, int pin_n)
4949

5050
void port_init(port_t *obj, PortName port, int mask, PinDirection dir)
5151
{
52-
#if 0//revise me
53-
obj->port = port;
54-
obj->mask = mask;
5552

56-
CMSDK_GPIO_TypeDef *port_reg =
57-
(CMSDK_GPIO_TypeDef *)(CMSDK_GPIO0_BASE + ((int)port * 0x10));
58-
59-
obj->reg_in = &port_reg->DATAOUT;
60-
obj->reg_dir = &port_reg->OUTENABLESET;
61-
obj->reg_dirclr = &port_reg->OUTENABLECLR;
62-
63-
uint32_t i;
64-
// The function is set per pin: reuse gpio logic
65-
for (i = 0; i < 16; i++) {
66-
if (obj->mask & (1 << i)) {
67-
gpio_set(port_pin(obj->port, i));
68-
}
69-
}
70-
71-
port_dir(obj, dir);
72-
#endif
7353
}
7454

7555
void port_mode(port_t *obj, PinMode mode)
7656
{
77-
#if 0//revise me
78-
uint32_t i;
79-
// The mode is set per pin: reuse pinmap logic
80-
for (i = 0; i < 32; i++) {
81-
if (obj->mask & (1 << i)) {
82-
pin_mode(port_pin(obj->port, i), mode);
83-
}
84-
}
85-
#endif
57+
8658
}
8759

8860
void port_dir(port_t *obj, PinDirection dir)
8961
{
90-
#if 0//revise me
91-
switch (dir) {
92-
case PIN_INPUT :
93-
*obj->reg_dir &= ~obj->mask;
94-
break;
95-
case PIN_OUTPUT:
96-
*obj->reg_dir |= obj->mask;
97-
break;
98-
}
99-
#endif
62+
10063
}
10164

10265
void port_write(port_t *obj, int value)

0 commit comments

Comments
 (0)