fix: acks, login, filters, and APRS_BOT_CALLSIGN #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several bugs: * message acks were not properly removing messages from the _waiting_ack expiring dict, so messages were being retried that had been ackd. This was due to an incorrect hashing algorithim that did not correctly identify packets. * login method now checks for proper login and sends app versions and filters properly. This also removes the APRS_LISTENING_CALLSIGNS that just did not work at all. There is no mechanism in Errbot of forwarding on a "reply-as" user for a message, so when a message for an additional callsign came in, all replies went out as just signed in callsigns. This is replaced by APRS_BOT_CALLSIGN, which allows setting the bot and reply-from to a callsign separate from the one you're using to sign into APRSIS. This is useful for running a service bot, like ANSRVR or WXBOT. The bot will still listen on the signed in callsign as well, but if messaged there, will repy with the APRS_BOT_CALLSIGN callsign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several bugs:
This also removes the APRS_LISTENING_CALLSIGNS that just did not work at all. There is no mechanism in Errbot of forwarding on a "reply-as" user for a message, so when a message for an additional callsign came in, all replies went out as just signed in callsigns.
This is replaced by APRS_BOT_CALLSIGN, which allows setting the bot and reply-from to a callsign separate from the one you're using to sign into APRSIS. This is useful for running a service bot, like ANSRVR or WXBOT. The bot will still listen on the signed in callsign as well, but if messaged there, will repy with the APRS_BOT_CALLSIGN callsign