Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.<function from another mixin> is undefined in browser (isomorphic app) #41

Open
captivationsoftware opened this issue Feb 14, 2015 · 0 comments

Comments

@captivationsoftware
Copy link

I've been experiencing a weird issue when using react-async in conjunction with react-router-component in my isomorphic app.

Given the following mixin:

    ...
    MyMixin = {
        foo: function() {
            console.log("hello!");
        }
    }
    ...

and the React class:

     ...
     var MyView = React.createClass({
        mixins: [Async.Mixin, MyMixin],

        getInitialStateAsync: function(cb) {
            this.foo(); //  only works in the browser
            ...
        }
        ...
    });

When mounting, the browser will throw an error saying this.foo() is undefined. The workaround is to do something like (courtesy of @theadam):

    ...
    var MyView = React.createClass({
        mixins: [Async.Mixin, MyMixin],

        getInitialStateAsync: function(cb) {
            var component = this.type && this.type.prototype ? this.type.prototype : this;
            component.foo(); // Works now
            ...
        }
    });

Obviously, the fix is less than ideal when using it in a larger app. Am I doing something wrong or is this an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants