-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library index #34
Comments
Why |
Cause submodules are in general thought to be private implementation details. At least that's my understanding of it. rationale: Lint.Utils.dedent`
Submodules of some packages are treated as private APIs and the import
paths may change without deprecation periods. It's best to stick with
top-level package exports.`, |
It's not a private API in this case. |
My understanding is that basically anyone can import any file within the package which is gonna work , but it may break if the file wasn't somehow announced as public and was moved between releases. However, each package has an entry file (i.e: |
I think The motivation behind splitting validated API into multiple top level modules is that those modules are optional — one can use only schema and other can validate data coming from JSON5 and yet another — from runtime JSON representation. Having all in the same module means that one have to bundle JSON5 parser even if they don't need it. |
Yeah. I don't necessarily disagree with you @andreypopp. It's a bit of a tricky issue IMHO. I started working on a prototype v3 a few months back that used a mono-repo approach (so you have |
It's possible that you're right. I'd say they exist to guard junior developers from making mistakes.
You mean just because |
Correct. |
Yeah, splitting into multiple packages will solve this issue. |
Correct with an asterisk. Tree shaking/minification would generally get rid of it if it's unused, but it's not guaranteed. |
Hi,
I've just stumbled upon the lint error emitted by tslint with very much default configuration:
Would it be possible to define the
index.js
file and re-export everything from there?The text was updated successfully, but these errors were encountered: