Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_standalone_toolchain installs mips64 when --arch=mips #312

Closed
davidshen84 opened this issue Mar 4, 2017 · 7 comments
Closed

make_standalone_toolchain installs mips64 when --arch=mips #312

davidshen84 opened this issue Mar 4, 2017 · 7 comments

Comments

@davidshen84
Copy link

davidshen84 commented Mar 4, 2017


Description

  1. Execute
android-ndk/build/tools/make_standalone_toolchain.py --arch mips --api 16 --stl libc++ --install-dir /opt/output/mips-toolchain
  1. Observe files created in /opt/output/mips-toolchain/bin

Expected: It creates mipsel-linux-android-* files.
Actual: It creates mips64el-linux-android-* files.

Environment Details

Not all of these will be relevant to every bug, but please provide as much
information as you can.

  • NDK Version: 14.0.3770861
  • Build sytem: standalone toolchain?
  • Host OS: Linux
  • Compiler: not related
  • ABI: mpis
  • STL: libc++
  • NDK API level: 16
  • Device API level: ??
@kneth
Copy link

kneth commented Mar 4, 2017

Similar to #310?

@DanAlbert
Copy link
Member

Yep. This is actually intentional, FYI. We install the mips64 toolchain and pass -m32 when building so it generates 32-bit code.

@enh
Copy link
Contributor

enh commented Mar 4, 2017

(this is how x86 and x86-64 work too. arm/aarch64 is actually the odd one out.)

@DanAlbert
Copy link
Member

We haven't actually made that change for x86 yet. mips32 was the trial run (they helpfully volunteered to do it for us) and it has yet to stick :)

@davidshen84
Copy link
Author

@DanAlbert Does it means the --arch mips and --arch mips64 for make_standalone_toolchain.py have the same effect? And we should add -m32 to CFLAGS and CXXFLAGS to distinguish the architecture?

@DanAlbert
Copy link
Member

If you're using Clang, it's something we do for you. I think if you haven't migrated off GCC yet you need to do so yourself, but I'd have to check to be sure (I'll do that when I'm looking at this on Monday).

@davidshen84
Copy link
Author

@DanAlbert Yes, I am still using GCC. Because OpenSSL build script only support GCC. If I change the compiler to clang, I got hit by #5.

Any suggestion for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants