Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does APP_SHORT_COMMANDS work with CMake? #972

Closed
aadithyabk opened this issue Apr 29, 2019 · 5 comments
Closed

Does APP_SHORT_COMMANDS work with CMake? #972

aadithyabk opened this issue Apr 29, 2019 · 5 comments
Labels

Comments

@aadithyabk
Copy link

ndk-build allows passing APP_SHORT_COMMANDS through gradle dsl but I can't find any documentation regarding the CMake equivalent or if the same works with CMake as well.

Just using APP_SHORT_COMMANDS=true as an argument for CMake in gradle results in an error because it is interpreted incorrectly. -DAPP_SHORT_COMMANDS does work but it can mean a custom preprocessor definition to CMake as well and I don't know if it has any effect. Neither me nor my teammates have a windows machine to test it completely and I felt it is easier to ask you folks.

@DanAlbert
Copy link
Member

No, it doesn't.

I'll have to dig around later and see if I can figure out the way to do this in CMake. It will be part of CMake proper rather than part of our interface, if that helps your search.

@alexcohn
Copy link

alexcohn commented Apr 30, 2019

I believe this answer can help. With gradle, you can pass

arguments "-DCMAKE_NINJA_FORCE_RESPONSE_FILE=1", "-DCMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS=1", "-DCMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=1", "-DCMAKE_C_RESPONSE_FILE_LINK_FLAG=@", "-DCMAKE_CXX_RESPONSE_FILE_LINK_FLAG=@"

but maybe it's easier to keep them in the top CMakeLists.txt.

@aadithyabk
Copy link
Author

Ah! Thanks for the link.

@DanAlbert
Copy link
Member

This is probably worth us mentioning in the externalNativeBuild docs. I'll leave this open to track that.

@DanAlbert DanAlbert reopened this Apr 30, 2019
@DanAlbert DanAlbert added this to the unscheduled docs milestone Apr 14, 2020
@DanAlbert
Copy link
Member

I haven't heard of this being a problem in a very long time. Maybe CMake is automatically enabling this when needed? I generally want to avoid repeating the CMake docs in our own docs, but if this is still relevant lmk and I can reopen.

@DanAlbert DanAlbert closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants