Does :core:testing module gets included in production release build?

[JackEblan]

I also want to verify if the fakes also get included in production. Is it okay to include fake classes from testing to production (To minimize a lil bit of apk size🤐)

[SimonMarquis]

Does :core:testing module gets included in production release build?

As long as it remain included only in "test" configurations like testImplementation or androidTestImplementation.
Which is the case at the moment: https://github.com/search?q=repo%3Aandroid%2Fnowinandroid+%22%28projects.core.testing%29%22&type=code

Is it okay to include fake classes from testing to production

Generally speaking, it is not okay to include fake (test) classes in the production app, simply because it is not meant to be used in production.

[JackEblan]

Can I ask about these classes here?
projects.core.network as the fakes are still here.

[SimonMarquis]

You are right, FakeNiaNetworkDataSource is actually bundled in the release sourceSet.
That being said, it is actually used in the demo flavor:

nowinandroid/core/network/src/demo/kotlin/com/google/samples/apps/nowinandroid/core/network/di/FlavoredNetworkModule.kt

Line 31 in ab90334

fun binds(impl: FakeNiaNetworkDataSource): NiaNetworkDataSource

And I guess this has been added here for simplicity. Also, keep in mind that, in prodRelease build type, R8 will probably strip these classes away.

[JackEblan]

Is it okay to move these to demo flavour including this

nowinandroid/core/network/src/main/kotlin/com/google/samples/apps/nowinandroid/core/network/di/NetworkModule.kt

Line 49 in ab90334

fun providesFakeAssetManager(

[SimonMarquis]

I think you'll also need to move all the test classes that rely on it, and this is probably why it remained here 😕

[JackEblan]

Hehe sorry😁 I don't want to touch it no more.