lint: mocha no-mocha-arrows autofix

mikehardy · mikehardy · commit 3e1ae63d06f2 · 2020-12-17T20:35:29.000-05:00
verified working locally after auto-fix https://mochajs.org/#arrow-functions https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-mocha-arrows.md
diff --git a/e2e/app.constants.e2e.js b/e2e/app.constants.e2e.js
@@ -15,17 +15,17 @@
  *
  */
 
-describe('App -> NativeModules -> Constants', () => {
-  describe('.apps', () => {
-    it('should be an array', () => {
+describe('App -> NativeModules -> Constants', function() {
+  describe('.apps', function() {
+    it('should be an array', function() {
       const { NATIVE_FIREBASE_APPS } = NativeModules.RNFBAppModule;
 
       NATIVE_FIREBASE_APPS.should.be.an.Array();
       // secondaryFromNative + default
       NATIVE_FIREBASE_APPS.length.should.equal(2);
     });
 
-    it('array items contain name, options & state properties', () => {
+    it('array items contain name, options & state properties', function() {
       const { NATIVE_FIREBASE_APPS } = NativeModules.RNFBAppModule;
 
       NATIVE_FIREBASE_APPS.should.be.an.Array();
diff --git a/e2e/app.e2e.js b/e2e/app.e2e.js
@@ -15,19 +15,19 @@
  *
  */
 
-describe('firebase', () => {
-  it('it should allow read the default app from native', () => {
+describe('firebase', function() {
+  it('it should allow read the default app from native', function() {
     // app is created in tests app before all hook
     should.equal(firebase.app()._nativeInitialized, true);
     should.equal(firebase.app().name, '[DEFAULT]');
   });
 
-  it('it should create js apps for natively initialized apps', () => {
+  it('it should create js apps for natively initialized apps', function() {
     should.equal(firebase.app('secondaryFromNative')._nativeInitialized, true);
     should.equal(firebase.app('secondaryFromNative').name, 'secondaryFromNative');
   });
 
-  it('natively initialized apps should have options available in js', () => {
+  it('natively initialized apps should have options available in js', function() {
     const platformAppConfig = FirebaseHelpers.app.config();
     should.equal(firebase.app().options.apiKey, platformAppConfig.apiKey);
     should.equal(firebase.app().options.appId, platformAppConfig.appId);
@@ -37,7 +37,7 @@ describe('firebase', () => {
     should.equal(firebase.app().options.storageBucket, platformAppConfig.storageBucket);
   });
 
-  xit('it should initialize dynamic apps', () => {
+  xit('it should initialize dynamic apps', function() {
     const name = `testscoreapp${FirebaseHelpers.id}`;
     const platformAppConfig = FirebaseHelpers.app.config();
     return firebase.initializeApp(platformAppConfig, name).then(newApp => {
@@ -48,24 +48,24 @@ describe('firebase', () => {
     });
   });
 
-  it('SDK_VERSION should return a string version', () => {
+  it('SDK_VERSION should return a string version', function() {
     firebase.SDK_VERSION.should.be.a.String();
   });
 });
 
-describe('firebase -> X', () => {
-  it('apps should provide an array of apps', () => {
+describe('firebase -> X', function() {
+  it('apps should provide an array of apps', function() {
     should.equal(!!firebase.apps.length, true);
     should.equal(firebase.apps.includes(firebase.app('[DEFAULT]')), true);
     return Promise.resolve();
   });
 
-  it('apps can get and set data collection', async () => {
+  it('apps can get and set data collection', async function() {
     firebase.app().automaticDataCollectionEnabled = false;
     should.equal(firebase.app().automaticDataCollectionEnabled, false);
   });
 
-  xit('apps can be deleted', async () => {
+  xit('apps can be deleted', async function() {
     const name = `testscoreapp${FirebaseHelpers.id}`;
     const platformAppConfig = FirebaseHelpers.app.config();
     const newApp = await firebase.initializeApp(platformAppConfig, name);
@@ -85,14 +85,14 @@ describe('firebase -> X', () => {
     }).should.throw(`No Firebase App '${name}' has been created - call firebase.initializeApp()`);
   });
 
-  xit('prevents the default app from being deleted', async () => {
+  xit('prevents the default app from being deleted', async function() {
     firebase
       .app()
       .delete()
       .should.be.rejectedWith('Unable to delete the default native firebase app instance.');
   });
 
-  it('extendApp should provide additional functionality', () => {
+  it('extendApp should provide additional functionality', function() {
     const extension = {};
     firebase.app().extendApp({
       extension,
diff --git a/e2e/config.e2e.js b/e2e/config.e2e.js
@@ -15,54 +15,54 @@
  *
  */
 
-describe('config', () => {
-  describe('meta', () => {
-    it('should read Info.plist/AndroidManifest.xml meta data', async () => {
+describe('config', function() {
+  describe('meta', function() {
+    it('should read Info.plist/AndroidManifest.xml meta data', async function() {
       const metaData = await NativeModules.RNFBAppModule.metaGetAll();
       metaData.rnfirebase_meta_testing_string.should.equal('abc');
       metaData.rnfirebase_meta_testing_boolean_false.should.equal(false);
       metaData.rnfirebase_meta_testing_boolean_true.should.equal(true);
     });
   });
 
-  describe('json', () => {
-    xit('should read firebase.json data', async () => {
+  describe('json', function() {
+    xit('should read firebase.json data', async function() {
       const jsonData = await NativeModules.RNFBAppModule.jsonGetAll();
       jsonData.rnfirebase_json_testing_string.should.equal('abc');
       jsonData.rnfirebase_json_testing_boolean_false.should.equal(false);
       jsonData.rnfirebase_json_testing_boolean_true.should.equal(true);
     });
   });
 
-  describe('prefs', () => {
-    beforeEach(async () => {
+  describe('prefs', function() {
+    beforeEach(async function() {
       await NativeModules.RNFBAppModule.preferencesClearAll();
     });
 
     // NOTE: "preferencesClearAll" clears Firestore settings. Set DB as emulator again.
-    after(async () => {
+    after(async function() {
       await firebase
         .firestore()
         .settings({ host: 'localhost:8080', ssl: false, persistence: true });
     });
 
-    it('should set bool values', async () => {
+    it('should set bool values', async function() {
       const prefsBefore = await NativeModules.RNFBAppModule.preferencesGetAll();
       should.equal(prefsBefore.invertase_oss, undefined);
       await NativeModules.RNFBAppModule.preferencesSetBool('invertase_oss', true);
       const prefsAfter = await NativeModules.RNFBAppModule.preferencesGetAll();
       prefsAfter.invertase_oss.should.equal(true);
     });
 
-    it('should set string values', async () => {
+    it('should set string values', async function() {
       const prefsBefore = await NativeModules.RNFBAppModule.preferencesGetAll();
       should.equal(prefsBefore.invertase_oss, undefined);
       await NativeModules.RNFBAppModule.preferencesSetString('invertase_oss', 'invertase.io');
       const prefsAfter = await NativeModules.RNFBAppModule.preferencesGetAll();
       prefsAfter.invertase_oss.should.equal('invertase.io');
     });
 
-    it('should clear all values', async () => {
+    it('should clear all values', async function() {
       await NativeModules.RNFBAppModule.preferencesSetString('invertase_oss', 'invertase.io');
       const prefsBefore = await NativeModules.RNFBAppModule.preferencesGetAll();
       prefsBefore.invertase_oss.should.equal('invertase.io');
diff --git a/e2e/events.e2e.js b/e2e/events.e2e.js
@@ -21,9 +21,9 @@ const eventBody = {
   foo: 'bar',
 };
 
-describe('Core -> EventEmitter', () => {
-  describe('ReactNativeFirebaseEventEmitter', () => {
-    it('queues events before app is ready', async () => {
+describe('Core -> EventEmitter', function() {
+  describe('ReactNativeFirebaseEventEmitter', function() {
+    it('queues events before app is ready', async function() {
       const { eventsPing, eventsNotifyReady, eventsGetListeners } = NativeModules.RNFBAppModule;
       await eventsNotifyReady(false);
 
@@ -57,7 +57,7 @@ describe('Core -> EventEmitter', () => {
       should.equal(nativeListenersAfter.events.pong, undefined);
     });
 
-    it('queues events before a js listener is registered', async () => {
+    it('queues events before a js listener is registered', async function() {
       const {
         eventsPing,
         eventsNotifyReady,
diff --git a/e2e/utils.e2e.js b/e2e/utils.e2e.js
@@ -15,32 +15,32 @@
  *
  */
 
-describe('utils()', () => {
-  describe('namespace', () => {
-    it('accessible from firebase.app()', () => {
+describe('utils()', function() {
+  describe('namespace', function() {
+    it('accessible from firebase.app()', function() {
       const app = firebase.app();
       should.exist(app.utils);
       app.utils().app.should.equal(app);
     });
   });
 
-  describe('isRunningInTestLab', () => {
-    it('returns true or false', () => {
+  describe('isRunningInTestLab', function() {
+    it('returns true or false', function() {
       should.equal(firebase.utils().isRunningInTestLab, false);
     });
   });
 
-  describe('playServicesAvailability', () => {
-    it('returns isAvailable and Play Service status', async () => {
+  describe('playServicesAvailability', function() {
+    it('returns isAvailable and Play Service status', async function() {
       const playService = await firebase.utils().playServicesAvailability;
       //iOS always returns { isAvailable: true, status: 0}
       should(playService.isAvailable).equal(true);
       should(playService.status).equal(0);
     });
   });
 
-  describe('getPlayServicesStatus', () => {
-    it('returns isAvailable and Play Service status', async () => {
+  describe('getPlayServicesStatus', function() {
+    it('returns isAvailable and Play Service status', async function() {
       const status = await firebase.utils().getPlayServicesStatus();
       //iOS always returns { isAvailable: true, status: 0}
       should(status.isAvailable).equal(true);
diff --git a/e2e/utilsStatics.e2e.js b/e2e/utilsStatics.e2e.js
@@ -15,9 +15,9 @@
  *
  */
 
-describe('utils()', () => {
-  describe('statics', () => {
-    it('provides native path strings', () => {
+describe('utils()', function() {
+  describe('statics', function() {
+    it('provides native path strings', function() {
       firebase.utils.FilePath.should.be.an.Object();
       if (device.getPlatform() === 'ios') {
         firebase.utils.FilePath.MAIN_BUNDLE.should.be.a.String();
