Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Absolute paths in manifest file is problematic #368

Open
netrounds-fredrik opened this issue Mar 16, 2017 · 1 comment
Open

Absolute paths in manifest file is problematic #368

netrounds-fredrik opened this issue Mar 16, 2017 · 1 comment

Comments

@netrounds-fredrik
Copy link

In the manifest file, the packages.install and packages.trusted-keys requires an absolute path to files. This is problematic since it makes it impossible to perform the build from any directory without first modifying the manifest file.

Quickly looking at the code, both InstallPackages and InstallTrustedKeys seems like they should be able to handle relative paths, as well as absolute paths.

To be able to distinguish a package name from a relative path in packages.install, I suggest using the same method as apt-get install, where relative paths starts with ./.

@andsens
Copy link
Owner

andsens commented Mar 16, 2017

Sounds like a great idea. Relative paths have been introduced in other parts of the manifest as well. We should stay with the practice of making them relative to the manifest as done in #341.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants