Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in isgreater #21

Open
tpgillam opened this issue Mar 12, 2023 · 0 comments
Open

Typo in isgreater #21

tpgillam opened this issue Mar 12, 2023 · 0 comments

Comments

@tpgillam
Copy link

function isgreater(a, b)
isless(b, a) || isequal(a, b)
end

Should be isgreater(a, b) = isless(b, a).

It's correct in the README though!

* `isgreater(a, b) = isless(b, a)`

In practice I think the tests don't catch this because they're only looking at the implementations of findall and findlast for these on UniqueSortIndex, which doesn't actually depend on the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant