You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In practice I think the tests don't catch this because they're only looking at the implementations of findall and findlast for these on UniqueSortIndex, which doesn't actually depend on the implementation.
The text was updated successfully, but these errors were encountered:
AcceleratedArrays.jl/src/predicates.jl
Lines 40 to 42 in a77ffde
Should be
isgreater(a, b) = isless(b, a)
.It's correct in the README though!
AcceleratedArrays.jl/README.md
Line 120 in a77ffde
In practice I think the tests don't catch this because they're only looking at the implementations of
findall
andfindlast
for these onUniqueSortIndex
, which doesn't actually depend on the implementation.The text was updated successfully, but these errors were encountered: