Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged Releases #17

Closed
opalmer opened this issue Oct 2, 2016 · 4 comments
Closed

Tagged Releases #17

opalmer opened this issue Oct 2, 2016 · 4 comments
Assignees
Milestone

Comments

@opalmer
Copy link
Contributor

opalmer commented Oct 2, 2016

So after using go-gerrit for a while I've been starting to think we should be tagging releases. There's a few reasons for this:

  • Vendoring can take advantage of this and lock down to specific versions of go-gerrit. You can technically do this with revisions too but tags are easier to work with and more obvious.
  • There's no a good way to handle breaking changes at the moment. For example, GetReflog can take from and to url parameters but the current implementation of go-gerrit does not support this. The change could be made in master now but it would be a breaking change and it does not feel appropriate to make a new function.
  • There have been several contributions for everything from new features to major bug fixes. It would be nice, though not a requirement, to keep a small changelog of these kinds of changes so when you upgrade from 0.1.0 to 0.1.1 you have a better understanding of changes between versions.
@opalmer
Copy link
Contributor Author

opalmer commented Oct 2, 2016

@andygrunwald, thoughts?

@andygrunwald
Copy link
Owner

Good idea. Go for it!
The only important note from my side: Release notes.
These release notes should add value and answer questions like "What is new? What bugs were fixed? Why should i upgrade? Any breaking changes for the upgrade and do i have to adjust my code?"

Personally i like the release notes from etcd, see https://github.com/coreos/etcd/releases
They are useful, clear and well structured.

@opalmer Afaik you own the rights to do releases and tags. If not ping me and i will grant those to you. Othwerwise: Good idea :)

Will you handle this ticket and close once a release is done?

@opalmer opalmer added this to the 0.1.0 milestone Oct 8, 2016
@opalmer opalmer self-assigned this Oct 8, 2016
@opalmer
Copy link
Contributor Author

opalmer commented Oct 8, 2016

Done! It's pretty close to what etcd does though not exactly (we don't have a NEWS file yet). For my own project, I made it a policy to update the changelog for every new PR, we probably could do the same here.

@opalmer opalmer closed this as completed Oct 8, 2016
@andygrunwald
Copy link
Owner

andygrunwald commented Oct 9, 2016

Awesome work. Thank you.
Regarding the changelog: Yes, why not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants