Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce consistent type hinting throughout toffy #208

Closed
alex-l-kong opened this issue Aug 12, 2022 · 1 comment
Closed

Enforce consistent type hinting throughout toffy #208

alex-l-kong opened this issue Aug 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@alex-l-kong
Copy link
Contributor

alex-l-kong commented Aug 12, 2022

Is your feature request related to a problem? Please describe.

A lot of modules (ex. tiling_utils.py) don't consistently enforce type hinting rules. This is good practice to have, so in the long run, we should work on adding this in to all the Python modules.

Describe the solution you'd like

Add type hints to needed function parameters and doctrings. This can be done using the typing module.

@alex-l-kong alex-l-kong added the enhancement New feature or request label Aug 12, 2022
@ngreenwald
Copy link
Member

Can be incorporated into individual PRs when people make changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants