Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code action to close missing quotes for attributes #137

Closed
angelozerr opened this issue Sep 22, 2018 · 7 comments
Closed

Code action to close missing quotes for attributes #137

angelozerr opened this issue Sep 22, 2018 · 7 comments
Assignees
@angelozerr
Labels
code action enhancement New feature or request
Milestone
v0.5.0

Comments

@angelozerr
Copy link
Contributor

No description provided.

@angelozerr angelozerr mentioned this issue Sep 22, 2018
Merged
@fbricon fbricon added enhancement New feature or request code action labels Sep 22, 2018
@NikolasKomonen NikolasKomonen self-assigned this Sep 24, 2018
@NikolasKomonen
Copy link
Contributor

Follow : https://github.com/angelozerr/lsp4xml/tree/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/contentmodel/participants/codeactions

@fbricon fbricon added the to do label Sep 25, 2018
@angelozerr
Copy link
Contributor Author

@NikolasKomonen I suggest you to see 492212a

@fbricon fbricon added this to the v0.0.2 milestone Sep 26, 2018
@NikolasKomonen
Copy link
Contributor

@angelozerr We can close this?

@angelozerr
Copy link
Contributor Author

Me i have not implemented That but i Can Do it if you wish

@fbricon
Copy link
Contributor

fbricon commented Oct 10, 2018

Not sure this is a critical missing piece. It's as fast to add the missing quote manually, if not faster

@NikolasKomonen
Copy link
Contributor

@angelozerr what do you think about

Not sure this is a critical missing piece. It's as fast to add the missing quote manually, if not faster

Think we can close this?

@angelozerr
Copy link
Contributor Author

Think we can close this?

No please, it's implemented in few minutes, I will do it.

@fbricon fbricon assigned angelozerr and unassigned NikolasKomonen Oct 28, 2018
@fbricon fbricon modified the milestones: v0.0.2, v0.0.3 Nov 3, 2018
@fbricon fbricon removed the to do label Nov 3, 2018
@fbricon fbricon modified the milestones: v0.0.3, v0.0.4 Nov 13, 2018
@NikolasKomonen NikolasKomonen modified the milestones: v0.4.0, v0.5.0 Mar 1, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 19, 2019
@NikolasKomonen
CodeActions for missing attribute quotations
4575ade 
Fixes eclipse-lemminx#137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Mar 19, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 19, 2019
@NikolasKomonen
CodeActions for missing attribute quotations
daebfb8 
Fixes eclipse-lemminx#137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 21, 2019
@NikolasKomonen
CodeActions for missing attribute quotations
fa84007 
Fixes eclipse-lemminx#137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 3, 2019
@NikolasKomonen
CodeActions for missing attribute quotations
4c9eb01 
Fixes eclipse-lemminx#137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 4, 2019
@NikolasKomonen
CodeActions for missing attribute quotations
00309af 
Fixes eclipse-lemminx#137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
fbricon pushed a commit that referenced this issue Apr 4, 2019
@NikolasKomonen @fbricon
CodeActions for missing attribute quotations
9f2d414 
Fixes #137

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
code action enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen