Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for DTD <!ELEMENT, <!ATTRIBUTE, #232

Closed
angelozerr opened this issue Nov 15, 2018 · 3 comments
Closed

Completion for DTD <!ELEMENT, <!ATTRIBUTE, #232

angelozerr opened this issue Nov 15, 2018 · 3 comments
Assignees
@angelozerr
Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request in progress
Milestone
v0.3.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Nov 15, 2018 •
edited
Loading

Support for completion

  • for DTD elements

<! <- Ctrl+Space shows <!ELEMENTS <!ATTRIBUTE, <!ENTITY
@angelozerr angelozerr added enhancement New feature or request completion This issue or enhancement is related to completion support DTD labels Nov 15, 2018
@angelozerr angelozerr mentioned this issue Nov 15, 2018
Closed
@fbricon fbricon added this to the v0.0.4 milestone Nov 15, 2018
angelozerr added a commit that referenced this issue Nov 26, 2018
@angelozerr
Use DTD scanner to implement completion for DTD <!ELEMENT, <!ATTRIBUTE
cdb61dd 
(see #232)
@angelozerr angelozerr modified the milestones: v0.0.4, v0.0.3 Nov 30, 2018
angelozerr added a commit that referenced this issue Nov 30, 2018
@angelozerr
Add !ENTITY completion (see #232)
2e155e6
@angelozerr
Copy link
Contributor Author

@fbricon it's basic but it starts working:
dtdcompletion

@fbricon
Copy link
Contributor

fbricon commented Dec 5, 2018

If I type <, select "internal entity", autocompletion inserts <!ENTITY entity-name "entity-value" >, so I end up with 2 opening brackets.
Also the placeholders order is wrong. the value is selected first, it should be the entity name

@fbricon
Copy link
Contributor

fbricon commented Dec 20, 2018 •
edited
Loading

with the latest changes, typing < doesn't offer the completion anymore. cc @NikolasKomonen. Completion still shows up when ctrl+spacing on empty line though.

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 16, 2019
@NikolasKomonen
Fixes DTD completion
5736f5c 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Jan 16, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 17, 2019
@NikolasKomonen
Fixes DTD completion
baa14c3 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 18, 2019
@NikolasKomonen
Fixes DTD completion
a563d6d 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Fixes DTD completion
a996e2a 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Fixes DTD completion
e4667cd 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Fixes DTD completion
fb42647 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Fixes DTD completion
de6f709 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Fixes DTD completion
3ab04d9 
Fixes eclipse-lemminx#232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit that referenced this issue Jan 22, 2019
@NikolasKomonen
Fixes DTD completion (#281)
05895c4 
Fixes #232

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request in progress
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@fbricon @angelozerr