Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textDocument/definition for DTD #233

Closed
angelozerr opened this issue Nov 15, 2018 · 1 comment · Fixed by #544
Closed

Add support for textDocument/definition for DTD #233

angelozerr opened this issue Nov 15, 2018 · 1 comment · Fixed by #544
Assignees
@angelozerr
Labels
DTD enhancement New feature or request hyperlink
Milestone
v0.9.0

Comments

@angelozerr
Copy link
Contributor

Support for hyperlink between DTD elements.

<!ELEMENT TVSCHEDULE (CHANNEL <-- Ctrl+Click go at <!ELEMENT CHANNEL
<!ELEMENT CHANNEL (BANNER,DAY+)>
@angelozerr angelozerr added enhancement New feature or request DTD hyperlink labels Nov 15, 2018
@fbricon fbricon added this to the v0.0.4 milestone Nov 15, 2018
@angelozerr angelozerr mentioned this issue Nov 15, 2018
Closed
@NikolasKomonen NikolasKomonen removed this from the v0.4.0 milestone Jan 29, 2019
@angelozerr angelozerr added this to the v0.9.0 milestone Jul 24, 2019
@angelozerr angelozerr changed the title Support for hyperlink between DTD elements Add support for textDocument/definition for DTD Jul 24, 2019
angelozerr added a commit that referenced this issue Jul 24, 2019
@angelozerr
Add support for textDocument/definition for DTD
447d8d6 
Fixes #233

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 24, 2019
Merged
@angelozerr
Copy link
Contributor Author

To play with this PR, open the DTD https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/resources/dtd/svg.dtd

and do like the following demo:

DTDDefinitionWithSVG

It shoud work too when DOCTYPE inside XML is defined.

With this XML file:

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE note [
	<!ELEMENT note (to,from,heading,body)>
	<!ELEMENT to (#PCDATA)>
	<!ELEMENT from (#PCDATA)>
	<!ELEMENT heading (#PCDATA)>
	<!ELEMENT body (#PCDATA)>
]>
<note>
	<to>Tove</to>
	<from>Jani</from>
	<heading>Reminder</heading>
	<body>Don't forget me this weekend!</body>
</note>

Ctrl+Click on the first heading (declared in <!ELEMENT note (to,from,heading,body)>) should set the cursor to the declared heading ( <!ELEMENT heading (#PCDATA)>)

angelozerr added a commit that referenced this issue Jul 24, 2019
@angelozerr
Add support for textDocument/definition for DTD
723a613 
Fixes #233

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 24, 2019
@angelozerr
Add support for textDocument/definition for DTD
fb625c7 
Fixes #233

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this Jul 24, 2019
angelozerr added a commit that referenced this issue Jul 24, 2019
@angelozerr
Add support for textDocument/definition for DTD
5961c2d 
Fixes #233

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Aug 13, 2019
@angelozerr
Add support for textDocument/definition for DTD
8a3da66 
Fixes #233

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
DTD enhancement New feature or request hyperlink
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Add support for textDocument/definition for DTD eclipse-lemminx/lemminx
3 participants
@fbricon @angelozerr @NikolasKomonen