Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test with markdown on Windows OS. #487

Closed
angelozerr opened this issue Jul 1, 2019 · 0 comments · Fixed by #501
Closed

Fix test with markdown on Windows OS. #487

angelozerr opened this issue Jul 1, 2019 · 0 comments · Fixed by #501
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
v0.8.0

Comments

@angelozerr
Copy link
Contributor

On Windows OS test https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/utils/MarkdownConverterTest.java#L26 failed.

It's because the test hard code the line separator and parhaps remark or JSoup uses system line separator?
@angelozerr angelozerr added the bug Something isn't working label Jul 1, 2019
@fbricon fbricon added this to the v0.8.0 milestone Jul 3, 2019
angelozerr added a commit that referenced this issue Jul 4, 2019
@angelozerr
Fix test with markdown on Windows OS.
5df7323 
Fix #487

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 4, 2019
Merged
fbricon pushed a commit that referenced this issue Jul 4, 2019
@angelozerr @fbricon
Fix test with markdown on Windows OS.
2df4bec 
Fix #487

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Fix test with markdown on Windows OS. eclipse-lemminx/lemminx
2 participants
@fbricon @angelozerr