Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode fixes and tips #28

Closed
abierbaum opened this issue May 2, 2017 · 9 comments
Closed

vscode fixes and tips #28

abierbaum opened this issue May 2, 2017 · 9 comments

Comments

@abierbaum
Copy link

When using the vscode tslint plugin, I am presented with a "lightbulb" icon of tips for fixing the lint issues or disabling them. When running without the tslint plugin and just the language service I do not see a tip icon. Is this something that can be added or does it require a plugin to vscode to work?

@amatiasq
Copy link

Same thing here, after restarting vscode multiple times it didn't work. Now after 12 hours I saw the lightbulb icon on a linting issue but after I use a single quickfix I have to close and open the file again in order to see the lightbulb again :\

I guess it's related that the language service doesn't update when I type on the file.

@angelozerr
Copy link
Owner

@egamma have you an idea about this issue?

@egamma
Copy link
Contributor

egamma commented May 12, 2017

@angelozerr this looks like issue palantir/tslint#2649

My fix from this PR #20 is not in the published 0.9.3 module. I suspect the TypeScript code was not compiled before the node module was published and an older version got published.

@angelozerr
Copy link
Owner

My fix from this PR #20 is not in the published 0.9.3 module.

Oooops, sorry -( I have created a new release with 0.9.4. Sorry @egamma to have loosing your time.

@abierbaum @amatiasq could you retry with 0.9.4 please.

@abierbaum
Copy link
Author

@angelozerr @egamma Works perfect with 0.9.4. Thanks so much!!!

@egamma
Copy link
Contributor

egamma commented May 12, 2017

@abierbaum great, pls remember this restriction from the README

Notice due to an issue in the implementation of the no-unused-variable rule (issue15344]), this rule will be disabled by the plugin. You can use the typescript compiler options noUnusedLocals and noUnusedParameters instead.

@OliverJAsh
Copy link
Contributor

Hi, I am expecting to see a quick fix for this error but I don't see any. Using 0.9.4:

image

@OliverJAsh
Copy link
Contributor

My bad, quick fix only appears when the cursor is inside the error. Ignore the above.

@amatiasq
Copy link

@angelozerr Updated from version 0.9.3 to 0.9.6
Works perfectly now! Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants