Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace config system with Pyside's QSettings #1003

Open
twizmwazin opened this issue May 15, 2023 · 2 comments
Open

Replace config system with Pyside's QSettings #1003

twizmwazin opened this issue May 15, 2023 · 2 comments

Comments

@twizmwazin
Copy link
Member

Description

Currently we have our own config system implemented in angrmanagement.config. Instead of doing this ourselves, it would be a good idea to instead let QT handle this for us.

Alternatives

No response

Additional context

No response

@twizmwazin twizmwazin added enhancement needs-triage Issue has yet to be looked at by a maintainer and removed needs-triage Issue has yet to be looked at by a maintainer labels May 15, 2023
@ltfish
Copy link
Member

ltfish commented May 15, 2023

QSettings does not use toml and has some weird limitations (because it decides to use Windows Registry on Windows). I think using our own configuration system with a pure text-based backend will allow easier configuration backup and manual modification.

@twizmwazin
Copy link
Member Author

From glancing over the API docs it seems that custom formats are supported. Assuming that is true it should be possible to migrate to QSettings with a toml backend that preserves compatibility with existing configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants