Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for typescript files #6

Closed
GabeDuarteM opened this issue Jan 30, 2018 · 5 comments
Closed

Support for typescript files #6

GabeDuarteM opened this issue Jan 30, 2018 · 5 comments

Comments

@GabeDuarteM
Copy link

Currently, if i open a tsx file (typescript react) and try to use the extension, it gives me a message saying "Only available for javascript/react file types".

It would be nice to have support for typescript files as well...

What do you think?

@angryobject
Copy link
Owner

Check this #2 please.

For me it's easy to enable it for ts files, but there's no guarantee it'll work correctly.

@GabeDuarteM
Copy link
Author

Hmm, I see (sorry for not checking that earlier),

Maybe we could test it, and if it behaves mostly fine, it could be enabled as an experimental feature, enabled at the settings...

I think this is a very productive plugin, and not being able to use it on ts files is kind of a bummer for me, as most of my projects use typescript.

@angryobject
Copy link
Owner

Yes, that's a possibility. But i'm not familiar with TS myself so i don't know any usecases for it and can't write tests.

But i just thought may be i can just add this checkbox in settings, like "enable for TS files (might not work correctly, officially not supported)". Will see.

@angryobject
Copy link
Owner

You can now set reactPureToClass.typescript setting to true to enable ts files support. But it comes with no guarantees =)

@GabeDuarteM
Copy link
Author

I swear I thought I had replied here, but apparently, I didn't, sorry about that.

Thank you for adding that setting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants