-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Option to only allow requesting local songs #35
Comments
I think that.. could be possible. It would involve a prescan , and marking the song database with a "local" flag. I'll add it to my "todo" list. |
srm already does searches locally. |
Oh, just found that there apparently is an "OfflineMode" config setting which does that together with the local options? Might be good to add to the readme :) I guess this ticket could be about subs/mods bypassing that then. |
the offline mode stuff is partially broken - offline searches work, but not downloads/plays. It used to work :) So yeah, once that's fixed, it will work |
Can you clarify what "local search" vs. "offline mode" mean? Whenever beatsaver APIs are down, any request attempt simply results in "invalid id" errors, even if the song is already available locally. So if the purpose of local search is to allow requesting of local songs, it seems there is still a dependency on web services. |
Working on scanning the local directory now - coming soon (tm) |
offline mode lets you use a songdatabase file to bypass beatsaver.com for searches (but not downloads) |
OK, that makes sense, thanks. I wouldn't expect downloads to work. but a degraded mode for putting a local song into the queue without some of the real-time metadata (ratings, the code->song mapping) would often be preferable to no requests at all. |
It would be cool if there was a way to only allow requesting of local songs (and maybe make searching online a mod/sub feature). I guess this might also need a command to list possible local ones.
The text was updated successfully, but these errors were encountered: