Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to only allow requesting local songs #35

Open
Phoenix616 opened this issue Aug 3, 2020 · 8 comments
Open

[Feature Request] Option to only allow requesting local songs #35

Phoenix616 opened this issue Aug 3, 2020 · 8 comments

Comments

@Phoenix616
Copy link

It would be cool if there was a way to only allow requesting of local songs (and maybe make searching online a mod/sub feature). I guess this might also need a command to list possible local ones.

@angturil
Copy link
Owner

angturil commented Aug 3, 2020

I think that.. could be possible. It would involve a prescan , and marking the song database with a "local" flag. I'll add it to my "todo" list.

@angturil
Copy link
Owner

angturil commented Aug 3, 2020

srm already does searches locally.

@Phoenix616
Copy link
Author

Oh, just found that there apparently is an "OfflineMode" config setting which does that together with the local options? Might be good to add to the readme :)

I guess this ticket could be about subs/mods bypassing that then.

@angturil
Copy link
Owner

angturil commented Aug 4, 2020

the offline mode stuff is partially broken - offline searches work, but not downloads/plays. It used to work :) So yeah, once that's fixed, it will work

@YoukaiTheGit
Copy link

Can you clarify what "local search" vs. "offline mode" mean? Whenever beatsaver APIs are down, any request attempt simply results in "invalid id" errors, even if the song is already available locally. So if the purpose of local search is to allow requesting of local songs, it seems there is still a dependency on web services.

@angturil
Copy link
Owner

Working on scanning the local directory now - coming soon (tm)

@angturil
Copy link
Owner

offline mode lets you use a songdatabase file to bypass beatsaver.com for searches (but not downloads)
getting the file is tricky however ... and can't be done right now cause beatsaver is down.

@YoukaiTheGit
Copy link

OK, that makes sense, thanks. I wouldn't expect downloads to work. but a degraded mode for putting a local song into the queue without some of the real-time metadata (ratings, the code->song mapping) would often be preferable to no requests at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants