Skip to content

Commit 5e9b350

Browse files
committed
Merge pull request #1189 from kingcody/refactor/remove-migration-code
Refactor: remove migration code
2 parents b7c91ac + baeff6c commit 5e9b350

File tree

3 files changed

+20
-35
lines changed

3 files changed

+20
-35
lines changed

Diff for: app/index.js

-9
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,6 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
6161
jasmine: true
6262
});
6363

64-
// NOTE: temp(?) fix for #403
65-
if(typeof this.filters.oauth === 'undefined') {
66-
var strategies = Object.keys(this.filters).filter(function(key) {
67-
return key.match(/Auth$/) && this.filters[key];
68-
}.bind(this));
69-
70-
if(strategies.length) this.filters.oauth = true;
71-
}
72-
7364
this.config.set('filters', this.filters);
7465
this.config.forceSave();
7566

Diff for: test/fixtures/.yo-rc.json

+20-4
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,36 @@
11
{
22
"generator-angular-fullstack": {
3-
"insertRoutes": "true",
3+
"endpointDirectory": "server/api/",
4+
"insertRoutes": true,
45
"registerRoutesFile": "server/routes.js",
56
"routesNeedle": "// Insert routes below",
6-
"insertSockets": "true",
7+
"routesBase": "/api/",
8+
"pluralizeRoutes": true,
9+
"insertSockets": true,
710
"registerSocketsFile": "server/config/socketio.js",
811
"socketsNeedle": "// Insert sockets below",
12+
"insertModels": true,
13+
"registerModelsFile": "server/sqldb/index.js",
14+
"modelsNeedle": "// Insert models below",
915
"filters": {
1016
"coffee": true,
1117
"html": true,
1218
"less": true,
1319
"uirouter": true,
20+
"bootstrap": false,
21+
"uibootstrap": false,
1422
"socketio": true,
15-
"mongoose": true,
1623
"auth": true,
17-
"googleAuth": true
24+
"models": true,
25+
"mongooseModels": true,
26+
"mongoose": true,
27+
"oauth": true,
28+
"googleAuth": true,
29+
"grunt": true,
30+
"mocha": true,
31+
"jasmine": false,
32+
"should": true,
33+
"expect": false
1834
}
1935
}
2036
}

Diff for: test/test-file-creation.js

-22
Original file line numberDiff line numberDiff line change
@@ -467,28 +467,6 @@ describe('angular-fullstack generator', function () {
467467
});
468468
});
469469

470-
it('should add oauth option if existing config had oauth strategy selected', function(done) {
471-
this.timeout(60000);
472-
copySync(__dirname + '/fixtures/.yo-rc.json', __dirname + '/temp/.yo-rc.json');
473-
var gen = helpers.createGenerator('angular-fullstack:app', [
474-
'../../app',
475-
'../../endpoint',
476-
[
477-
helpers.createDummyGenerator(),
478-
'ng-component:app'
479-
]
480-
]);
481-
gen.options['skip-install'] = true;
482-
helpers.mockPrompt(gen, {
483-
skipConfig: true
484-
});
485-
gen.run(function () {
486-
var yoConfig = require(__dirname + '/temp/.yo-rc.json');
487-
expect(yoConfig['generator-angular-fullstack'].filters.oauth).to.be.true;
488-
done();
489-
});
490-
});
491-
492470
it('should generate expected files', function (done) {
493471
gen.run(function () {
494472
helpers.assertFile(genFiles(defaultOptions));

0 commit comments

Comments
 (0)