Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devtools window prop name #58

Merged
merged 9 commits into from
Jan 3, 2019

Conversation

wtho
Copy link
Contributor

@wtho wtho commented Dec 12, 2018

  • update prop devToolsExtension to __REDUX_DEVTOOLS_EXTENSION__
  • add package redux-devtools-extension for typings
  • define some typings for window

The listen-callback still works (at least START was fired on load, not sure how to test STOP), and there were no issues with the extension. Dispatching from the extension worked flawlessly.

I added the package redux-devtools-extension to give users of this library intellisense for the option types when initializing the devtools-enhancer. I decided against importing devtoolsEnhancer from the same package, as it kind of hides if the devtools were connected successfully or not, and the isEnabled-function in @angular-redux/store would still be required and does a very similar check. So better to rely only on isEnabled if we require it anyways.

wtho and others added 3 commits December 12, 2018 16:22
- update prop 'devToolsExtension' to '__REDUX_DEVTOOLS_EXTENSION__'
- add package redux-devtools-extension for typings
- define some typings for window
Was added by mistake
@wtho
Copy link
Contributor Author

wtho commented Dec 14, 2018

Updated backwards compatibility and removed lint-ignore.

Btw, this closes #56.

Copy link
Member

@jamesbs jamesbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fvilers
Copy link

fvilers commented Dec 19, 2018

Hi! Great work guys. Any estimation on a release date?

@jamesbs jamesbs changed the base branch from master to upgrade-angular-7 December 20, 2018 21:19
@jamesbs jamesbs changed the base branch from upgrade-angular-7 to master December 20, 2018 21:19
@e-schultz e-schultz merged commit 9c8d034 into angular-redux:master Jan 3, 2019
@wtho wtho deleted the update-redux-devtools branch January 3, 2019 18:19
jamesbs pushed a commit to jamesbs/platform that referenced this pull request Jan 7, 2019
* chore(store): update devtools window prop name

- update prop 'devToolsExtension' to '__REDUX_DEVTOOLS_EXTENSION__'
- add package redux-devtools-extension for typings
- define some typings for window

* Delete package-lock.json

Was added by mistake

* fix(devtools): add backwards compatibility

* fix(devtools): backwards compat deToolsExtension

* Add yarn.lock changes

* fix: adjust formatting to comply with prettier
smithad15 pushed a commit that referenced this pull request May 4, 2019
Adds support for the new '__REDUX_DEVTOOLS_EXTENSION__' window property
github-actions bot pushed a commit to adrianiy/platform that referenced this pull request Sep 28, 2021
# ngredux-store-v1.0.0 (2021-09-28)

### Bug Fixes

* fix eslint ([ab4d1d3](ab4d1d3))
* **build:** No chai for you ([#209](https://github.com/AdrianInsua/platform/issues/209)) ([be35f03](be35f03))
* **deps:** Change zone.js version ([#222](https://github.com/AdrianInsua/platform/issues/222)) ([e62e149](e62e149))
* **example:** Fix local dev mode ([angular-redux#80](https://github.com/AdrianInsua/platform/issues/80)) ([angular-redux#81](https://github.com/AdrianInsua/platform/issues/81)) ([b06721f](b06721f))
* **ngReduxModule:** Generate metadata ([#237](https://github.com/AdrianInsua/platform/issues/237)) ([8b4b9d8](8b4b9d8))
* **package.json:** add redux as dependencies ([angular-redux#132](https://github.com/AdrianInsua/platform/issues/132)) ([5fdeb19](5fdeb19))

### chore

* **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9)
* **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4)

### Features

* add bootstraping script ([3fd7b32](3fd7b32))
* add new devtools window prop name ([angular-redux#58](https://github.com/AdrianInsua/platform/issues/58)) ([55b15a6](55b15a6))
* bump angular version to 11.0.5 ([1b8bb72](1b8bb72))
* Introduced a new function called provideStore() which accepts a already created Redux store ([angular-redux#142](https://github.com/AdrianInsua/platform/issues/142)) ([a6c4aaf](a6c4aaf)), closes [angular-redux#141](https://github.com/AdrianInsua/platform/issues/141)
* refactor packages to match new ng-packager ([710edef](710edef))
* upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79)
* Typescript Port ([angular-redux#33](https://github.com/AdrianInsua/platform/issues/33)) ([33ea991](33ea991)), closes [angular-redux#35](https://github.com/AdrianInsua/platform/issues/35) [angular-redux#36](https://github.com/AdrianInsua/platform/issues/36) [angular-redux#37](https://github.com/AdrianInsua/platform/issues/37) [angular-redux#38](https://github.com/AdrianInsua/platform/issues/38) [angular-redux#39](https://github.com/AdrianInsua/platform/issues/39) [angular-redux#52](https://github.com/AdrianInsua/platform/issues/52) [angular-redux#50](https://github.com/AdrianInsua/platform/issues/50) [angular-redux#55](https://github.com/AdrianInsua/platform/issues/55) [angular-redux#53](https://github.com/AdrianInsua/platform/issues/53)
* **aot:** Support AoT - [#223](https://github.com/AdrianInsua/platform/issues/223) ([#226](https://github.com/AdrianInsua/platform/issues/226)) ([a6d7826](a6d7826))
* **dispatch:** Create dispatch decorator ([#385](https://github.com/AdrianInsua/platform/issues/385)) ([4513566](4513566))

### BREAKING CHANGES

* Upgrades Angular dependencies to v7
* **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour
- peer dependencies have been corrected to actual dependencies
* **linting:** - ConnectArray has been renamed to ConnectArrayDirective
- ReactiveConnect has been renamed to ReactiveConnectDirective
- Connect has been renamed to ConnectDirective
- interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
github-actions bot pushed a commit to adrianiy/platform that referenced this pull request Sep 28, 2021
# @adrian.insua/ngredux-store-v1.0.0 (2021-09-28)

### Bug Fixes

* change package names to be user scoped ([c0c9d1d](c0c9d1d))
* fix eslint ([ab4d1d3](ab4d1d3))
* **build:** No chai for you ([#209](https://github.com/AdrianInsua/platform/issues/209)) ([be35f03](be35f03))
* **deps:** Change zone.js version ([#222](https://github.com/AdrianInsua/platform/issues/222)) ([e62e149](e62e149))
* **example:** Fix local dev mode ([angular-redux#80](https://github.com/AdrianInsua/platform/issues/80)) ([angular-redux#81](https://github.com/AdrianInsua/platform/issues/81)) ([b06721f](b06721f))
* **ngReduxModule:** Generate metadata ([#237](https://github.com/AdrianInsua/platform/issues/237)) ([8b4b9d8](8b4b9d8))
* **package.json:** add redux as dependencies ([angular-redux#132](https://github.com/AdrianInsua/platform/issues/132)) ([5fdeb19](5fdeb19))

### chore

* **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9)
* **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4)

### Features

* add bootstraping script ([3fd7b32](3fd7b32))
* add new devtools window prop name ([angular-redux#58](https://github.com/AdrianInsua/platform/issues/58)) ([55b15a6](55b15a6))
* bump angular version to 11.0.5 ([1b8bb72](1b8bb72))
* Introduced a new function called provideStore() which accepts a already created Redux store ([angular-redux#142](https://github.com/AdrianInsua/platform/issues/142)) ([a6c4aaf](a6c4aaf)), closes [angular-redux#141](https://github.com/AdrianInsua/platform/issues/141)
* refactor packages to match new ng-packager ([710edef](710edef))
* upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79)
* Typescript Port ([angular-redux#33](https://github.com/AdrianInsua/platform/issues/33)) ([33ea991](33ea991)), closes [angular-redux#35](https://github.com/AdrianInsua/platform/issues/35) [angular-redux#36](https://github.com/AdrianInsua/platform/issues/36) [angular-redux#37](https://github.com/AdrianInsua/platform/issues/37) [angular-redux#38](https://github.com/AdrianInsua/platform/issues/38) [angular-redux#39](https://github.com/AdrianInsua/platform/issues/39) [angular-redux#52](https://github.com/AdrianInsua/platform/issues/52) [angular-redux#50](https://github.com/AdrianInsua/platform/issues/50) [angular-redux#55](https://github.com/AdrianInsua/platform/issues/55) [angular-redux#53](https://github.com/AdrianInsua/platform/issues/53)
* **aot:** Support AoT - [#223](https://github.com/AdrianInsua/platform/issues/223) ([#226](https://github.com/AdrianInsua/platform/issues/226)) ([a6d7826](a6d7826))
* **dispatch:** Create dispatch decorator ([#385](https://github.com/AdrianInsua/platform/issues/385)) ([4513566](4513566))

### BREAKING CHANGES

* Upgrades Angular dependencies to v7
* **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour
- peer dependencies have been corrected to actual dependencies
* **linting:** - ConnectArray has been renamed to ConnectArrayDirective
- ReactiveConnect has been renamed to ReactiveConnectDirective
- Connect has been renamed to ConnectDirective
- interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants