Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular v15 support #158

Closed
EdricChan03 opened this issue Nov 22, 2022 · 10 comments · May be fixed by jcharra/bee-notes#38, jcharra/bee-notes#39, jcharra/bee-notes#40 or jcharra/bee-notes#41
Closed

Angular v15 support #158

EdricChan03 opened this issue Nov 22, 2022 · 10 comments · May be fixed by jcharra/bee-notes#38, jcharra/bee-notes#39, jcharra/bee-notes#40 or jcharra/bee-notes#41
Assignees

Comments

@EdricChan03
Copy link
Contributor

EdricChan03 commented Nov 22, 2022

Angular v15 was recently released. Are there plans to add Angular v15 support?

@JohannesHoppe
Copy link
Member

Thank you for pointing this out. There are no breaking changes. I will quickly create a new release today.

@EdricChan03
Copy link
Contributor Author

EdricChan03 commented Nov 23, 2022

Thanks for the quick response! I've just attempted to update to 1.0.4 and I've noticed that it still produces a peer dependencies error:

❯ npm i angular-cli-ghpages@latest
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: <project>@<version>
npm ERR! Found: @angular-devkit/architect@0.1500.0
npm ERR! node_modules/@angular-devkit/architect
npm ERR!   dev @angular-devkit/architect@"^0.1500.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular-devkit/architect@">= 0.900 < 0.1500" from angular-cli-ghpages@1.0.4
npm ERR! node_modules/angular-cli-ghpages
npm ERR!   dev angular-cli-ghpages@"1.0.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Looking at the commit that added Angular v15 support shows that the version range for @angular-devkit/architect wasn't bumped as well.

EDIT: I've since opened a PR (#159) that should fix this regression

@JohannesHoppe
Copy link
Member

🙏 here is the new relase: https://github.com/angular-schule/angular-cli-ghpages/releases/tag/v1.0.5

@mammadkoma
Copy link

I created a new repository in github
ng add Angular15
cd Angular15
git init
git remote add origin https://github.com/mammadkoma/Angular15.git
ng add angular-cli-ghpages
ng deploy --repo=https://github.com/mammadkoma/Angular15.git

It shows this message : 🌟 Successfully published via angular-cli-ghpages! Have a nice day!
but it doesn't work in my github pages: https://mammadkoma.github.io/Angular15/

@fmalcher
Copy link
Member

@mammadkoma In your case, the deployment worked fine, so your problem doesn't seem to be related to the library.
If you want to deploy to a subfolder, you need to use the --base-href option as described here: https://github.com/angular-schule/angular-cli-ghpages#--base-href-

@mammadkoma
Copy link

mammadkoma commented Nov 29, 2022

I don't want to deploy to a subfolder. I executed the command in your gif in the npm site.
I tested this command : ng deploy --base-href=/angular15/
But not work
image
image

@JohannesHoppe
Copy link
Member

The tool is working as expected. This is not a support channel for individual projects.

@mammadkoma
Copy link

This is not individual project , it is created only by ng new angular15 command like your npm documents. Please create a new angular 15 project and deploy to your github. If it works show us the steps. Thank you

@EdricChan03
Copy link
Contributor Author

@mammadkoma I've taken a look at your GitHub repository and have discovered a potential cause of the issue: your repository is named as "Angular15" (notice the capitalisation), but you've configured your --base-href to use "angular15".

Attempting to visit https://mammadkoma.github.io/Angular15/ does yield the HTML as expected, but the site breaks with 404 errors due to the issue mentioned above:

Screenshot of Firefox DevTools Console showing 404 errors on the Angular15 subpage

Hope this helps!

@mammadkoma
Copy link

Finally worked Thanks
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment