Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 404.html when deploying localized Angular 18 app #192

Open
sondreb opened this issue Jun 14, 2024 · 3 comments
Open

Missing 404.html when deploying localized Angular 18 app #192

sondreb opened this issue Jun 14, 2024 · 3 comments

Comments

@sondreb
Copy link

sondreb commented Jun 14, 2024

I have an Angular 18 app that I've added the standard i18n (internationalization) support for Angular.

This means the output of my app are multiple folders with copies of the same app, in different languages.

When I now run deploy using this package, it no longer generates the 404 (not on root and not within the language folders).

Is there some option or something to make it work with localization?

@JohannesHoppe
Copy link
Member

We haven't changed any details here, the 404.html is still created?!

@sondreb
Copy link
Author

sondreb commented Jun 14, 2024

When moving from a single language to multi language app, it outputs "en", "no", "fr" sub-folders, each individual copies of the whole app. When doing the deploy, it doesn't create any 404 anymore (after I added multiple languages).

@JohannesHoppe
Copy link
Member

I see your point. The command wont copy the index.html to 404.html because it can't find it. There should be a warning message about this. Do you think you can come up with a solution for this? First we should recognise the different folder structure, then we should copy all the index.html files. PRs are highly welcome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants